Page MenuHomePhabricator
Create Task
Maniphest T112676

DateInputWidget does not support $overlay
Closed, ResolvedPublic
Actions

Description

DateInputWidget does not support $overlay.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
mw.widgets.DateInputWidget: Implement $overlay config optionBartosz Dziewońskimediawiki/coremaster+65 -3
Introduce FloatableElement mixinBartosz Dziewońskioojs/uimaster+178 -72
Customize query in gerrit

Related Objects
Search...

Event Timeline

• matmarex created this task.Sep 15 2015, 5:33 PM
• matmarex claimed this task.
• matmarex raised the priority of this task from to Needs Triage.
• matmarex updated the task description. (Show Details)
• matmarex added projects: OOUI, MediaWiki-General.
• matmarex added subscribers: • Prtksxna, • matmarex.
Herald added a subscriber: Aklapper. · View Herald TranscriptSep 15 2015, 5:33 PM
• matmarex added a parent task: T91717: Be able to embed an upload dialog so that other extensions (e.g. WikiEditor, VisualEditor) can provide it to users.Sep 16 2015, 5:08 PM
• matmarex added a comment.Sep 16 2015, 7:40 PM

I've got this working locally, but it involved copy-pasting most of FloatingMenuSelectWidget into CalendarWidget. I'm going to extract a FloatableElement mixing from them.

gerritbot subscribed.Sep 16 2015, 10:39 PM

Change 238990 had a related patch set uploaded (by Bartosz Dziewoński):
Introduce FloatableElement mixin

https://gerrit.wikimedia.org/r/238990

gerritbot added a project: Patch-For-Review.Sep 16 2015, 10:39 PM
gerritbot added a comment.Sep 16 2015, 11:00 PM

Change 238998 had a related patch set uploaded (by Bartosz Dziewoński):
mw.widgets.DateInputWidget: Implement $overlay config option

https://gerrit.wikimedia.org/r/238998

gerritbot added a comment.Sep 22 2015, 5:40 PM

Change 238990 merged by jenkins-bot:
Introduce FloatableElement mixin

https://gerrit.wikimedia.org/r/238990

• matmarex mentioned this in rGOJUc76fd3dd407d: Introduce FloatableElement mixin.Sep 22 2015, 5:40 PM
gerritbot added a comment.Sep 29 2015, 12:33 PM

Change 238998 merged by jenkins-bot:
mw.widgets.DateInputWidget: Implement $overlay config option

https://gerrit.wikimedia.org/r/238998

• matmarex mentioned this in rMW7133d749c23b: mw.widgets.DateInputWidget: Implement $overlay config option.Sep 29 2015, 12:33 PM
• matmarex closed this task as Resolved.Sep 29 2015, 1:59 PM
• matmarex triaged this task as Medium priority.
• matmarex removed a project: Patch-For-Review.
• matmarex set Security to None.
ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)), MW-1.27-release-notes.Sep 29 2015, 10:16 PM
Jdforrester-WMF edited projects, added: MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:48 AM
• matmarex edited projects, added: MW-1.26-release; removed: MW-1.27-release-notes.Oct 16 2015, 6:43 PM

Patches cherry-picked to REL1_26 in 03e6ac38bf51456d9035b58040422358c41939f7.

Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Nov 21 2015, 2:30 AM
Volker_E moved this task from Reviewing to OOjs-UI-0.12.9 on the OOUI board.Apr 15 2017, 9:38 AM
Volker_E edited projects, added: OOUI (OOjs-UI-0.12.9); removed: OOUI.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits