Page MenuHomePhabricator

Obscure CirrusSearch error gives wrong error message "There were no search results" when using insource keyword
Open, LowestPublic

Description

On Wikipedia:

hastemplate:"Val" insource:/\{\{[Vv]al\|[^}]*m\// prefix: : runs in a snap.

NOW ADD AN "s" at the end for "m\/s", and it takes so long that it times out, saying, consistently " There were no results matching the query."

That is a problem, because it is obviously in error: There are plenty of pages that match that search without the "s", many of them showing the "s" clearly in the match. It should report a timeout error or some other kind of error.

NOW ADD ONE MORE CHARACTER in the pattern, such that we no longer have the "/s at the end" problem:

hastemplate:"Val" insource:/\{\{[Vv]al\|[^}]*m\/s[|}]/ prefix: : then it runs in a snap again.

Mainspace has 1275 pages with template Val.
Userspace has 626 pages. (Change to `prefix:User')
That can't possibly be too many pages to "crawl character-by-regexp-character" through.

Userspace has 10 pages that match the target: Val .*m/s
Mainspace has 73 pages that match the failed search. (It works by adding another character to the pattern.)

This seems to be a throttle limit, because it takes a long time (it's slow), but most telling, it works for prefix:User:.
The only difference being the number of pages. It barely works for user space. But then why not an error msg?
I refer you to https://discuss.elastic.co/t/how-to-protect-an-es-cluster-from-searches-that-would-kill-it/25487

Event Timeline

Cpiral created this task.Sep 16 2015, 4:57 AM
Cpiral raised the priority of this task from to Needs Triage.
Cpiral updated the task description. (Show Details)
Cpiral added a project: CirrusSearch.
Cpiral added a subscriber: Cpiral.
Restricted Application added a project: Discovery. · View Herald TranscriptSep 16 2015, 4:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Smalyshev moved this task from Needs triage to Search on the Discovery board.Oct 19 2015, 9:49 PM
ksmith set Security to None.
Deskana triaged this task as Lowest priority.Dec 3 2015, 5:48 PM
Deskana added a subscriber: Deskana.

We have very limited capacity to be able to support fixing these kinds of bugs, so I am lowering the priority of this task to reflect reality.

Deskana renamed this task from Obscure CirrusSearch error gives wrong error message "There were no search results" to Obscure CirrusSearch error gives wrong error message "There were no search results" when using insource keyword.Dec 30 2015, 9:31 PM