Page MenuHomePhabricator
Create Task
Maniphest T112788

Promise returned from LogEvent should resolve when logging is complete
Closed, DeclinedPublic1 Estimated Story Points
Actions

Description

LogEvent returns a promise, but right now it's always already resolved or rejected. It would be nice if it resolved after we knew the event had been logged. Can still resolve immediately when not tracking or using sendBeacon, but we should resolve when the image loads if using the fallback <img> tag method.

https://gerrit.wikimedia.org/r/238623

Details

SubjectRepoBranchLines +/-
Resolve beacon promise asyncmediawiki/extensions/EventLoggingmaster+24 -7
Break out sendBeacon implementationsmediawiki/extensions/EventLoggingmaster+49 -19
Customize query in gerrit

Event Timeline

Ejegg created this task.Sep 16 2015, 5:50 PM
Ejegg raised the priority of this task from to Needs Triage.
Ejegg updated the task description. (Show Details)
Ejegg added a project: MediaWiki-extensions-EventLogging.
Ejegg subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2015, 5:50 PM
gerritbot subscribed.Sep 16 2015, 5:53 PM

Change 238623 had a related patch set uploaded (by Ejegg):
Resolve beacon promise async

https://gerrit.wikimedia.org/r/238623

gerritbot added a project: Patch-For-Review.Sep 16 2015, 5:53 PM
Ejegg claimed this task.Sep 16 2015, 6:15 PM
Ejegg triaged this task as Medium priority.
Ejegg added projects: Fundraising Sprint Snoop (Dogg|Lion), Unplanned-Sprint-Work.
Ejegg set Security to None.
Ejegg edited a custom field.
gerritbot added a comment.Sep 16 2015, 6:21 PM

Change 238629 had a related patch set uploaded (by Ejegg):
Break out sendBeacon implementations

https://gerrit.wikimedia.org/r/238629

Ejegg moved this task from Backlog to Review on the Fundraising Sprint Snoop (Dogg|Lion) board.Sep 16 2015, 6:21 PM
• atgo added a project: Fundraising-Backlog.Sep 16 2015, 10:06 PM
• atgo moved this task from Triage to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.
• DStrine added a project: Fundraising Sprint Tom Waits.Sep 17 2015, 1:12 AM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Tom Waits board.Sep 17 2015, 8:09 PM
awight moved this task from Review to Pending Deployment on the Fundraising Sprint Tom Waits board.Sep 22 2015, 8:07 PM
Ejegg added a subscriber: awight.Sep 23 2015, 8:36 PM

@awight, did you move this by mistake? I'm getting -1ed by nuria on the basis that 'LogEvent is supposed to be fire-and-forget', arguing to remove the promise entirely

awight added a comment.Sep 23 2015, 8:38 PM

Sorry, it looks like I never CR+1'd even, yeah still review or doing, then!

• Nuria subscribed.Sep 23 2015, 8:39 PM

@Ejegg Thank you for your changes , sorry I could not get to review them sooner.

Ejegg moved this task from Pending Deployment to Review on the Fundraising Sprint Tom Waits board.Sep 23 2015, 8:43 PM
• Nuria added a project: Analytics-Backlog.Sep 24 2015, 3:51 PM
• Nuria moved this task from Incoming to Radar on the Analytics-Backlog board.
Ejegg closed this task as Declined.Sep 30 2015, 10:40 PM

Seems to be a no-go in EventLogging, we'll just directly create the img in CentralNotice for non-beacon browsers.

• DStrine moved this task from Review to Done on the Fundraising Sprint Tom Waits board.Sep 30 2015, 10:41 PM
gerritbot added a comment.Sep 30 2015, 10:42 PM

Change 238623 abandoned by Ejegg:
Resolve beacon promise async

Reason:
Will implement this in CN instead

https://gerrit.wikimedia.org/r/238623

gerritbot added a comment.Sep 30 2015, 10:42 PM

Change 238629 abandoned by Ejegg:
Break out sendBeacon implementations

https://gerrit.wikimedia.org/r/238629

• mmodell removed a subscriber: awight.Jun 22 2017, 9:37 PM
Restricted Application added a project: Analytics. · View Herald TranscriptJun 22 2017, 9:37 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL