Page MenuHomePhabricator

tile source requires at least two characters, should be one
Open, LowPublic

Description

For some reason, expres' path expression does not match single character values, thus forcing us to use at least two chars for the tile sources.

/:src([A-Za-z][-A-Za-z0-9_]*)/...

Event Timeline

Yurik raised the priority of this task from to Low.
Yurik updated the task description. (Show Details)
Yurik added a project: Maps.
Yurik added subscribers: Yurik, MaxSem.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Yurik this issue is resolved right? The RegEx now present in Sources.sourceIdReStr seams to handle one character ids fine.

@Abbe98 have you tried creating a single-letter source? I'm ok with closing this issue, as its not really "issue-worthy"

@Yurik not successfully, but the regex itself should match single characters.

Tried to rename the source in sources.external.yaml, but I assume it wasn't suposed to work. Poking around to learn the different pieces...

This might be a bug/limitation of the express engine routing matching?

Triage note: If still present, this is a bug that will need fixing.