Page MenuHomePhabricator

colordiff: command not found
Closed, ResolvedPublic



00:01:44.652 + colordiff --brief output-parent output-proposed
00:01:44.652 /tmp/ line 19: colordiff: command not found

Seen at

Event Timeline

zeljkofilipin claimed this task.
zeljkofilipin raised the priority of this task from to High.
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin added subscribers: zeljkofilipin, hashar.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2015, 9:45 PM is totally useless without colordiff :(

I can't seem to even log into that slave either...

km@km-tp ~> ssh ci-jessie-wikimedia-51.eqiad.wmnet
channel 0: open failed: administratively prohibited: open failed
stdio forwarding failed
ssh_exchange_identification: Connection closed by remote host

I have migrated the Jenkins job integration-jjb-config-diff to the Nodepool instances. They for now only include the puppet classes:

  • apt
  • contint::packages::python

colordiff is added via contint::packages but that class can not really be applied for now. Bunch of packages are missing on Jessie.

So we probably want to extract from contint::packages to a new class then use it for both the light slaves and the nodepool images.

Change 239044 had a related patch set uploaded (by Zfilipin):
WIP Extract colordiff to contint::packages::colordiff

Change 239047 had a related patch set uploaded (by Zfilipin):
Make sure colordiff is installed on nodepool instances

Change 239044 merged by Giuseppe Lavagetto:
contint: move some useful packags to a new base class

Change 239365 had a related patch set uploaded (by Hashar):
nodepool: run integration/config puppet manifest on setup

Change 239047 merged by jenkins-bot:
nodepool: contint::packages::base in images

Change 239365 merged by jenkins-bot:
nodepool: run integration/config puppet manifest on setup

hashar closed this task as Resolved.Sep 18 2015, 8:14 PM

This is now solved ( )

In puppet we had to extract colordiff out of contint::packages.

Puppet was only run when building a new reference image (with dib). We also need to run it when creating a snapshot with the latest puppet and integration/config repo. I have sent a few related patches in integration/config.

Once changes got merged, on labnodepool I refreshed /etc/nodepool/wikimedia then updated the snapshot and deleted old instances.

In the process, I have largely improved the documentation at