Page MenuHomePhabricator
Create Task
Maniphest T112868

Babel AutoCreate creates incorrectly named and duplicated categories on multiple WMF wikis
Closed, ResolvedPublic
Actions

Description

It is creating wrong categories, instead of the patten "Category:User <code>-<level>" from 16 set 2015 it is creating new categories "Category:<code>-<level>". See mw:Extension:Babel#Configuration. --V.Riullop (talk) 10:40, 17 September 2015 (UTC)

Details

SubjectRepoBranchLines +/-
registration: Fix merging of array_plusmediawiki/coreREL1_25+3 -3
registration: Fix merging of array_plusmediawiki/coremaster+3 -3
registration: Fix merging of array_plusmediawiki/corewmf/1.26wmf22+3 -3
registration: Fix merging of array_plusmediawiki/corewmf/1.26wmf23+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Steinsplitter created this task.Sep 17 2015, 10:43 AM
Steinsplitter raised the priority of this task from to High.
Steinsplitter updated the task description. (Show Details)
Steinsplitter added projects: MediaWiki-Configuration, MediaWiki-extensions-Babel.
Steinsplitter subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2015, 10:43 AM
Steinsplitter added a comment.Sep 17 2015, 10:43 AM

https://commons.wikimedia.org/wiki/Commons:Administrators'_noticeboard/Blocks_and_protections#Babel_AutoCreate

Steinsplitter added a project: Wikimedia-Site-requests.Sep 17 2015, 10:43 AM
Steinsplitter set Security to None.
Restricted Application added subscribers: Dereckson, Matanya. · View Herald TranscriptSep 17 2015, 10:43 AM
Vriullop subscribed.Sep 17 2015, 10:45 AM
Aklapper removed a project: MediaWiki-Configuration.Sep 17 2015, 11:20 AM

What are exact steps to reproduce and see the problem?

Aklapper added a comment.Sep 17 2015, 11:23 AM

Ah. https://commons.wikimedia.org/wiki/Category:User_es-4 vs https://commons.wikimedia.org/w/index.php?title=Category:Es-4&action=history and the latter being created by an account called https://commons.wikimedia.org/wiki/User:Babel_AutoCreate which is part of the babel codebase.

Aklapper renamed this task from Babel AutoCreate to Babel AutoCreate creates incorrectly named and duplicated categories on Commons.Sep 17 2015, 11:24 AM
revi subscribed.Sep 17 2015, 11:27 AM

It's not specific to Commons; I found incorrect babel category (Ko-N, En-3) created on kowikinews, kowikiversity.

Aklapper renamed this task from Babel AutoCreate creates incorrectly named and duplicated categories on Commons to Babel AutoCreate creates incorrectly named and duplicated categories on multiple WMF wikis.Sep 17 2015, 11:40 AM
Aklapper added subscribers: Nemo_bis, Parent5446.Sep 17 2015, 11:45 AM

The two most recent Babel code changes touch category related code.
They are https://gerrit.wikimedia.org/r/#/c/237481/ as a followup to https://gerrit.wikimedia.org/r/#/c/213300/

CC'ing @Nemo_bis and @Parent5446

Nemo_bis assigned this task to Legoktm.EditedSep 17 2015, 1:35 PM

Yes, this needs a backport. https://gerrit.wikimedia.org/r/#q,If0cb5d9a303a28dc7d7f7bb7bcdf6263e63655e9,n,z

Nevermind, it's already deployed. No idea then.

Nemo_bis removed Legoktm as the assignee of this task.Sep 17 2015, 1:39 PM
Nemo_bis added a subscriber: Legoktm.
Krenair subscribed.Sep 17 2015, 3:42 PM
> var_dump( $wgBabelCategoryNames );
array(7) {
  [0]=>
  string(8) "%code%-0"
  [1]=>
  string(8) "%code%-1"
  [2]=>
  string(8) "%code%-2"
  [3]=>
  string(8) "%code%-3"
  [4]=>
  string(8) "%code%-4"
  [5]=>
  string(8) "%code%-5"
  ["N"]=>
  string(8) "%code%-N"
}

But the config for that wiki is supposed to be this:

		'0' => 'User %code%-0',
		'1' => 'User %code%-1',
		'2' => 'User %code%-2',
		'3' => 'User %code%-3',
		'4' => 'User %code%-4',
		'5' => false,
		'N' => 'User %code%-N'
Vriullop added a comment.Sep 17 2015, 4:09 PM

I also found incorrect categories on cawiktionary, previously configured per T49287: Configure $wgBabelCategoryNames for ca.wiktionary

Legoktm added a comment.Sep 17 2015, 5:13 PM
legoktm@terbium:~$ mwscript eval.php --wiki=commonswiki
> return $wmgBabelCategoryNames;
array(7) {
  [0]=>
  string(13) "User %code%-0"
  [1]=>
  string(13) "User %code%-1"
  [2]=>
  string(13) "User %code%-2"
  [3]=>
  string(13) "User %code%-3"
  [4]=>
  string(13) "User %code%-4"
  [5]=>
  bool(false)
  ["N"]=>
  string(13) "User %code%-N"
}
> return $wgBabelCategoryNames;
array(7) {
  [0]=>
  string(8) "%code%-0"
  [1]=>
  string(8) "%code%-1"
  [2]=>
  string(8) "%code%-2"
  [3]=>
  string(8) "%code%-3"
  [4]=>
  string(8) "%code%-4"
  [5]=>
  string(8) "%code%-5"
  ["N"]=>
  string(8) "%code%-N"
}
>
Legoktm claimed this task.Sep 17 2015, 5:29 PM
gerritbot subscribed.Sep 17 2015, 5:29 PM

Change 239140 had a related patch set uploaded (by Legoktm):
registration: Fix merging of array_plus

https://gerrit.wikimedia.org/r/239140

gerritbot added a project: Patch-For-Review.Sep 17 2015, 5:29 PM
gerritbot added a comment.Sep 17 2015, 5:32 PM

Change 239141 had a related patch set uploaded (by Legoktm):
registration: Fix merging of array_plus

https://gerrit.wikimedia.org/r/239141

gerritbot added a comment.Sep 17 2015, 5:32 PM

Change 239142 had a related patch set uploaded (by Legoktm):
registration: Fix merging of array_plus

https://gerrit.wikimedia.org/r/239142

gerritbot added a comment.Sep 17 2015, 5:34 PM

Change 239142 merged by Legoktm:
registration: Fix merging of array_plus

https://gerrit.wikimedia.org/r/239142

Legoktm mentioned this in rMWdad5a2cc5da2: registration: Fix merging of array_plus.Sep 17 2015, 5:34 PM
gerritbot added a comment.Sep 17 2015, 5:36 PM

Change 239141 merged by Legoktm:
registration: Fix merging of array_plus

https://gerrit.wikimedia.org/r/239141

Legoktm mentioned this in rMW87f820e99122: registration: Fix merging of array_plus.Sep 17 2015, 5:36 PM
gerritbot added a comment.Sep 17 2015, 5:41 PM

Change 239140 merged by jenkins-bot:
registration: Fix merging of array_plus

https://gerrit.wikimedia.org/r/239140

Legoktm mentioned this in rMW0a83ef3cf765: registration: Fix merging of array_plus.Sep 17 2015, 5:41 PM
Legoktm added a comment.Sep 17 2015, 5:42 PM

Fix has been deployed, so no new bad categories will be created. I'll work on a script to delete the bad ones that were created.

ReleaseTaggerBot added projects: MW-1.26-release, WMF-deploy-2015-09-22_(1.26wmf24), WMF-deploy-2015-09-08_(1.26wmf22), WMF-deploy-2015-09-15_(1.26wmf23).Sep 17 2015, 6:00 PM
Glaisher moved this task from Backlog to Working on on the Wikimedia-Site-requests board.Sep 21 2015, 3:42 PM
gerritbot added a comment.Sep 23 2015, 8:05 PM

Change 240565 had a related patch set uploaded (by Legoktm):
registration: Fix merging of array_plus

https://gerrit.wikimedia.org/r/240565

gerritbot added a comment.Sep 23 2015, 8:45 PM

Change 240565 merged by jenkins-bot:
registration: Fix merging of array_plus

https://gerrit.wikimedia.org/r/240565

Legoktm mentioned this in rMW470ee7abe596: registration: Fix merging of array_plus.Sep 23 2015, 8:46 PM
JAnD subscribed.Sep 25 2015, 9:47 AM
Aklapper added a comment.Sep 28 2015, 10:05 AM
In T112868#1650047, @Legoktm wrote:

I'll work on a script to delete the bad ones that were created.

@Legoktm: Has that happened in the meantime?

matej_suchanek subscribed.Sep 28 2015, 1:34 PM
Multichill subscribed.Sep 28 2015, 6:06 PM

Nuked a bunch of incorrectly named categories on Wikidata and Commons

ReleaseTaggerBot added a project: MW-1.25-release.Sep 29 2015, 8:02 PM
matej_suchanek added a comment.Oct 2 2015, 6:14 PM

New cases, with rich deletion history:

Multichill added a comment.Oct 2 2015, 8:48 PM

Blocked the bot on both Wikidata and Commons. This bot is causing more harm than good.

• demon removed a project: MW-1.25-release.Oct 22 2015, 4:47 PM
• demon removed a project: MW-1.26-release.
Nikki subscribed.Oct 28 2015, 4:27 PM

Any update on this? There are still around 4000 of these categories that need deleting, I've even seen a few where someone created a Wikidata item.

@matej_suchanek: That's not the same problem as the one here, see T63993 for those.

Nemo_bis added a comment.Oct 31 2015, 8:48 AM

Any update on this? There are still around 4000 of these categories that need deleting

You'd probably have better luck asking a deletion bot at https://meta.wikimedia.org/wiki/Steward_requests/Miscellaneous

Dereckson mentioned this in T63993: Babel language codes should be normalised to lower case when used in categories.Dec 31 2015, 3:57 PM
matej_suchanek removed a project: Patch-For-Review.Jan 22 2016, 1:07 PM
Restricted Application added a subscriber: JEumerus. · View Herald TranscriptJan 22 2016, 1:07 PM
Glaisher subscribed.Mar 12 2016, 8:46 AM
Matiia subscribed.Mar 21 2016, 3:39 AM
Peachey88 subscribed.Mar 31 2016, 3:24 PM
In T112868#1680225, @Aklapper wrote:
In T112868#1650047, @Legoktm wrote:

I'll work on a script to delete the bad ones that were created.

@Legoktm: Has that happened in the meantime?

@Legoktm, Ping Again, or should we just close out this ticket?

Although I'm guessing most of the other communities have already dealt with this already (I just did the ~37 on mw.wiki)

Nikki added a comment.Mar 31 2016, 4:08 PM

I asked a few weeks ago at https://meta.wikimedia.org/wiki/Steward_requests/Miscellaneous#Badly_named_Babel_AutoCreate_categories and a couple of people have been helping delete them. It seems like progress has stalled though.

Legoktm removed Legoktm as the assignee of this task.Mar 31 2016, 4:12 PM

Sorry for dropping the ball on this.

zhuyifei1999 subscribed.Apr 10 2016, 11:31 AM
MarcoAurelio mentioned this in T132296: Stop Babel AutoCreate until bugs are fixed.Apr 10 2016, 4:06 PM
NahidSultan subscribed.Apr 12 2016, 9:06 AM
Stang subscribed.Jul 15 2016, 7:35 AM
Superchilum subscribed.Aug 20 2016, 9:06 AM

In the meanwhile Babel Autocreate is still running and creating wrong categories, at least on it.wiki, it.wikiquote and en.wikiquote: for example "Category:User zh-Hans" or "Category:User de-AT" with wrong capitalization, where the correct categories "User zh-hans" and "User de-at" already exist.

Nikki added a comment.Aug 20 2016, 10:48 AM

@Superchilum This particular ticket was about a bug last year which has been fixed (not yet closed because we're still waiting for the last three badly named categories to be deleted - if anyone has admin access on wikimediafoundation.org, please have a look at the metawiki link above). See T63993 for the problem of inconsistent capitalisation (which was "fixed" a couple of days ago... in a way which uses the wrong capitalisation).

Superchilum added a comment.Aug 20 2016, 10:52 AM

Thank you :)

Nikki closed this task as Resolved.Oct 15 2016, 12:56 PM
Nikki claimed this task.

The last of the categories created by this were finally deleted: https://meta.wikimedia.org/w/index.php?title=Steward_requests/Miscellaneous&diff=15857612&oldid=15854367

Nikki removed Nikki as the assignee of this task.Oct 15 2016, 12:57 PM
Stang unsubscribed.Oct 21 2016, 12:18 PM
matej_suchanek unsubscribed.Jan 27 2017, 3:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL