Page MenuHomePhabricator
Create Task
Maniphest T112889

Adding Latin American Spanish as language code
Closed, ResolvedPublic
Actions

Description

I checked this with Amir over email, moving the conversation here.

We will be running a fundraising campaign in Latin America sometime next calendar year, for now the campaign is planned for April but we are working on a big tech integration for this, so plans might change.

Is there a way we can create a new language code on Meta for Latin American Spanish? The same way we have pt-br as a language code, that we use for Brazil campaigns, it would be great if we can have a language code for 'standard Latin American Spanish'. While LATAM Spanish varies between different countries, there is a 'standard version' that is accepted across countries, often used in advertising, subtitles etc.

Thanks for your feedback.

Details

SubjectRepoBranchLines +/-
Add core es-419 support via hookmediawiki/extensions/LandingCheckmaster+34 -0
Add core es-419 support via hookmediawiki/extensions/FundraiserLandingPagemaster+29 -1
Add the es-419 language code to support South American Spanishmediawiki/corefundraising/REL1_27+1 -0
Enable es-419 for DonationInterfacetranslatewikimaster+6 -0
PremadeMediawikiExtensionGroups: Add support for language white/blacklistsmediawiki/extensions/Translatemaster+42 -2
Make more consistent the behavior of MessageGroupBase::getTranslatableLanguagesmediawiki/extensions/Translatemaster+28 -13
Enable more languages in Special:Translate and Special:SearchTranslationsmediawiki/extensions/Translatemaster+7 -8
Add the es-419 language code to support South American Spanishmediawiki/coremaster+1 -0
Disable es-419 for translations by defaulttranslatewikimaster+1 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT199680 Fundraising in Latin American Spanish
 ResolvedNikerabbitT112889 Adding Latin American Spanish as language code

Event Timeline

• jrobell created this task.Sep 17 2015, 2:54 PM
• jrobell assigned this task to Amire80.
• jrobell raised the priority of this task from to Needs Triage.
• jrobell updated the task description. (Show Details)
• jrobell added subscribers: • jrobell, Pcoombe, Nikerabbit.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2015, 2:54 PM
Krenair added a project: MediaWiki-Internationalization.Sep 17 2015, 3:28 PM
Krenair subscribed.
Nemo_bis renamed this task from Adding LATAM Spanish as language code to Adding Latin American Spanish as language code.Sep 17 2015, 7:51 PM
Nemo_bis set Security to None.
• jrobell added a comment.Feb 18 2016, 12:37 PM

Hi @Amire80

I am checking back in on this again to see if adding Latin American Spanish as a language code would be possible? Could you please advice.

Thank you!

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptFeb 18 2016, 12:37 PM
Nikerabbit moved this task from Backlog to Language changes on the MediaWiki-Internationalization board.Jul 14 2016, 7:52 AM
Pcoombe added a comment.Feb 7 2018, 9:19 PM

@jrobell Just to clarify, even if this is added we would still need separate banners because the default people see will still be es (just like we need separate banners for Brazilian Portuguese, despite the fact it has its own language code).

This could still be helpful for payments forms, donatewiki and pages like Ways to Give.

• jrobell added a comment.Feb 8 2018, 9:34 AM

Thank you for chiming in @Pcoombe. Yeah, that sounds right to me. The additional language code would be super helpful also for the thank you email that donors receive. With the current flow and only one language code for es we cannot send a separate thank you email to Latin American donors vs Spanish donors in Spain, even though they saw two separate banners with localized appeals in their language variations.

Nikerabbit claimed this task.May 24 2018, 8:19 AM
Nikerabbit added projects: Language-2018-Apr-June, User-Nikerabbit.
Nikerabbit added a subscriber: Amire80.
Pginer-WMF triaged this task as High priority.May 29 2018, 7:48 AM
Pginer-WMF moved this task from Backlog to Maintenance backlog on the Language-2018-Apr-June board.
Nikerabbit moved this task from Maintenance backlog to In Progress on the Language-2018-Apr-June board.Jun 14 2018, 7:56 AM
gerritbot subscribed.Jun 14 2018, 7:57 AM

Change 440278 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Enable more languages in Special:Translate and Special:SearchTranslations

https://gerrit.wikimedia.org/r/440278

gerritbot added a project: Patch-For-Review.Jun 14 2018, 7:57 AM

Change 440280 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/core@master] Add es-419

https://gerrit.wikimedia.org/r/440280

gerritbot added a comment.Jun 14 2018, 8:01 AM

Change 440282 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[translatewiki@master] Disable es-419 for translations by default

https://gerrit.wikimedia.org/r/440282

Nikerabbit moved this task from In Progress to In Review on the Language-2018-Apr-June board.Jun 14 2018, 9:20 AM
gerritbot added a comment.Jun 15 2018, 1:00 PM

Change 440282 merged by jenkins-bot:
[translatewiki@master] Disable es-419 for translations by default

https://gerrit.wikimedia.org/r/440282

Nikerabbit added a comment.Jun 18 2018, 10:03 AM

After all my patches are merged, the following is expected:

  • MediaWiki knows about code es-419, i.e. it has a name and it is included in Language::fetchLanguageNames( null, 'mw' )
  • It is not selectable as interface language directly, but uselang=es-419 can be used, but there is no automatic fallback to es
  • Translatable wiki pages can be translated to es-419
  • MediaWiki and extensions cannot be localised to es-419 unless specifically enabled.

@jrobell @Pcoombe Do you think this will be sufficient?

Pcoombe added a comment.Jun 18 2018, 2:30 PM

@Nikerabbit That sounds good to me! So we could then manually enable es-419 localisation for DonationInterface extension?

How difficult would it be to add fallback to es? Not a big deal if it's hard, but it would be helpful.

Nikerabbit added a comment.Jun 18 2018, 2:36 PM
In T112889#4297051, @Pcoombe wrote:

That sounds good to me! So we could then manually enable es-419 localisation for DonationInterface extension?

Yes, I will submit a patch for that in translatewiki.net configuration.

How difficult would it be to add fallback to es? Not a big deal if it's hard, but it would be helpful.

Technically easy, except adding a fallback makes es-419 available as in interface language, which I was trying to avoid. To add a fallback without making it available will require some more coding. I am mainly thinking that it would be easy to do after T190129 (but that won't be ready in near future).

gerritbot added a comment.Jun 24 2018, 7:00 PM

Change 440280 merged by jenkins-bot:
[mediawiki/core@master] Add the es-419 language code to support South American Spanish

https://gerrit.wikimedia.org/r/440280

gerritbot added a comment.Jun 24 2018, 7:05 PM

Change 440278 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Enable more languages in Special:Translate and Special:SearchTranslations

https://gerrit.wikimedia.org/r/440278

gerritbot added a comment.Jun 26 2018, 8:43 AM

Change 442033 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Make more consistent the behavior of MessageGroupBase::getTranslatableLanguages

https://gerrit.wikimedia.org/r/442033

gerritbot added a comment.Jun 26 2018, 8:43 AM

Change 442034 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] PremadeMediawikiExtensionGroups: Add support for language white/blacklists

https://gerrit.wikimedia.org/r/442034

gerritbot added a comment.Jun 26 2018, 8:45 AM

Change 442035 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[translatewiki@master] Enable es-419 for DonationInterface

https://gerrit.wikimedia.org/r/442035

gerritbot added a comment.Jun 27 2018, 11:35 AM

Change 442033 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Make more consistent the behavior of MessageGroupBase::getTranslatableLanguages

https://gerrit.wikimedia.org/r/442033

gerritbot added a comment.Jun 28 2018, 5:31 AM

Change 442034 merged by Nikerabbit:
[mediawiki/extensions/Translate@master] PremadeMediawikiExtensionGroups: Add support for language white/blacklists

https://gerrit.wikimedia.org/r/442034

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 3:01 PM
Mahir256 subscribed.Jul 2 2018, 9:15 PM

Any reason why the language code for this isn't 'es-x-Q653884' or something similar, in the same way language codes are being devised for lexemes at present?

Nikerabbit added a comment.Jul 3 2018, 6:36 AM

I have no idea how language codes are being devised for lexemes, can you tell more?

Regardless, the answer is: Published standard language codes are always preferred over opaque private use extensions.

Nikerabbit added a comment.Jul 3 2018, 6:37 AM

@Pcoombe Could you have a look at my question in https://gerrit.wikimedia.org/r/442035?

gerritbot added a comment.Jul 6 2018, 4:54 PM

Change 442035 merged by jenkins-bot:
[translatewiki@master] Enable es-419 for DonationInterface

https://gerrit.wikimedia.org/r/442035

Nikerabbit removed a project: Patch-For-Review.Jul 6 2018, 9:03 PM
Pginer-WMF edited projects, added Language-2018-July-September; removed Language-2018-Apr-June.Jul 10 2018, 6:59 AM
Pginer-WMF moved this task from Backlog to In Review on the Language-2018-July-September board.
Arrbee moved this task from In Review to Done on the Language-2018-July-September board.Jul 10 2018, 7:29 AM
Arrbee closed this task as Resolved.Jul 16 2018, 7:11 AM
Pcoombe added a comment.Jul 16 2018, 12:43 PM

@Nikerabbit Thanks for the help! I confirmed that DonationInterface on translatewiki, and wiki pages, can both be translated into es-419, español de América Latina.

In the absence of a fallback, would it be possible to bulk copy over the existing es translations for DonationInterface to es-419 to get us started?

Pcoombe added a parent task: T199680: Fundraising in Latin American Spanish.Jul 16 2018, 1:06 PM
Ejegg subscribed.Jul 16 2018, 3:19 PM

@Pcoombe I think we should be able to do that just by copying the es.json file in the extension to es-419.json.

We'll also have to backport @Nikerabbit's patch to the payments-wiki branch, since that wiki runs on the LTS version of mediawiki and not the latest master.

Pcoombe added a comment.Jul 16 2018, 4:49 PM

Oof, I forgot payments runs on a different version. Thanks @Ejegg for the reminder, and for looking at copying the messages over!

gerritbot added a comment.Oct 17 2018, 7:06 PM

Change 468067 had a related patch set uploaded (by Ejegg; owner: Nikerabbit):
[mediawiki/core@fundraising/REL1_27] Add the es-419 language code to support South American Spanish

https://gerrit.wikimedia.org/r/468067

gerritbot added a project: Patch-For-Review.Oct 17 2018, 7:06 PM
gerritbot added a comment.Oct 18 2018, 7:10 PM

Change 468067 merged by jenkins-bot:
[mediawiki/core@fundraising/REL1_27] Add the es-419 language code to support South American Spanish

https://gerrit.wikimedia.org/r/468067

Quiddity mentioned this in T214238: Add es-ES Language to Wikidata.Apr 3 2019, 12:20 AM
gerritbot added a comment.Feb 24 2021, 2:31 AM

Change 666513 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Add core es-419 support via hook

https://gerrit.wikimedia.org/r/666513

gerritbot added a comment.Feb 24 2021, 11:21 PM

Change 666753 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/FundraiserLandingPage@master] Add core es-419 support via hook

https://gerrit.wikimedia.org/r/666753

gerritbot added a comment.Feb 24 2021, 11:53 PM

Change 666760 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/LandingCheck@master] Add core es-419 support via hook

https://gerrit.wikimedia.org/r/666760

gerritbot added a comment.Feb 24 2021, 11:54 PM

Change 666753 abandoned by Ejegg:
[mediawiki/extensions/FundraiserLandingPage@master] Add core es-419 support via hook

Reason:
Doing this in LandingCheck instead (Ib1d87522962b799b0a0f7f3eeaf4c140f3f20df9)

https://gerrit.wikimedia.org/r/666753

gerritbot added a comment.Mar 19 2021, 8:30 PM

Change 666760 merged by jenkins-bot:
[mediawiki/extensions/LandingCheck@master] Add core es-419 support via hook

https://gerrit.wikimedia.org/r/666760

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 19 2021, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL