Page MenuHomePhabricator

Handle Amazon SDK client communication failures and any other error that bubbles up to the Mediawiki API
Closed, ResolvedPublic2 Story Points

Description

We're only handling ResponseProcessingExceptions in a way that the client-side code can provide useful feedback. We should wrap all SDK client calls in a try..catch and handle communications errors like we do in other gateways.

Client-side code should also check for errors that bubble up to the API error handler and do something appropriate.

Details

Related Gerrit Patches:
mediawiki/extensions/DonationInterface : masterSend Amazon donor to fail page on unknown errors
mediawiki/extensions/DonationInterface : masterHandle errors thrown by Amazon SDK

Event Timeline

Ejegg created this task.Sep 17 2015, 6:23 PM
Ejegg claimed this task.
Ejegg raised the priority of this task from to Medium.
Ejegg updated the task description. (Show Details)
Ejegg added a subscriber: Ejegg.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2015, 6:23 PM
Ejegg set Security to None.Sep 17 2015, 8:10 PM
Ejegg edited a custom field.

Change 239284 had a related patch set uploaded (by Ejegg):
Handle errors thrown by Amazon SDK

https://gerrit.wikimedia.org/r/239284

Change 239284 merged by jenkins-bot:
Handle errors thrown by Amazon SDK

https://gerrit.wikimedia.org/r/239284

Change 240740 had a related patch set uploaded (by Ejegg):
Send Amazon donor to fail page on unknown errors

https://gerrit.wikimedia.org/r/240740

Change 240740 merged by jenkins-bot:
Send Amazon donor to fail page on unknown errors

https://gerrit.wikimedia.org/r/240740

Ejegg closed this task as Resolved.Sep 24 2015, 10:08 PM