Maniphest T112924

Handle Amazon SDK client communication failures and any other error that bubbles up to the Mediawiki API
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

We're only handling ResponseProcessingExceptions in a way that the client-side code can provide useful feedback. We should wrap all SDK client calls in a try..catch and handle communications errors like we do in other gateways.

Client-side code should also check for errors that bubble up to the API error handler and do something appropriate.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Send Amazon donor to fail page on unknown errors	mediawiki/extensions/DonationInterface	master	+21 -14
	Handle errors thrown by Amazon SDK	mediawiki/extensions/DonationInterface	master	+77 -42

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T93302 Big English Fundraiser - December
		Resolved		None	T87625 [epic] Amazon upgrade
		Resolved		None	T108106 [EPIC] Amazon embedded 1-hour test version
		Resolved		Ejegg	T112924 Handle Amazon SDK client communication failures and any other error that bubbles up to the Mediawiki API

Event Timeline

Ejegg created this task.Sep 17 2015, 6:23 PM

Ejegg claimed this task.

Ejegg raised the priority of this task from to Medium.

Ejegg updated the task description. (Show Details)

Ejegg added projects: Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Fundraising Sprint Tom Waits.

Ejegg subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2015, 6:23 PM

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Tom Waits board.Sep 17 2015, 6:24 PM

Ejegg set Security to None.Sep 17 2015, 8:10 PM

Ejegg edited a custom field.

Change 239284 had a related patch set uploaded (by Ejegg):
Handle errors thrown by Amazon SDK

https://gerrit.wikimedia.org/r/239284

gerritbot added a project: Patch-For-Review.Sep 17 2015, 9:10 PM

Change 239284 merged by jenkins-bot:
Handle errors thrown by Amazon SDK

https://gerrit.wikimedia.org/r/239284

Ejegg mentioned this in rEDOIf6889885f2f3: Handle errors thrown by Amazon SDK.Sep 18 2015, 6:10 PM

Ejegg mentioned this in rMEXT35fa264dea8b: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….

Ejegg added a parent task: T108106: [EPIC] Amazon embedded 1-hour test version .Sep 18 2015, 8:12 PM

• DStrine moved this task from Triage to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.Sep 21 2015, 7:00 PM

Change 240740 had a related patch set uploaded (by Ejegg):
Send Amazon donor to fail page on unknown errors

https://gerrit.wikimedia.org/r/240740

Ejegg moved this task from Doing to Review on the Fundraising Sprint Tom Waits board.Sep 24 2015, 4:58 PM

Change 240740 merged by jenkins-bot:
Send Amazon donor to fail page on unknown errors

https://gerrit.wikimedia.org/r/240740

Ejegg mentioned this in rEDOI920f91905a53: Send Amazon donor to fail page on unknown errors.Sep 24 2015, 5:52 PM

Ejegg mentioned this in rMEXT24d1c7321bf5: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Tom Waits board.Sep 24 2015, 8:00 PM

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Tom Waits board.Sep 24 2015, 9:29 PM

Ejegg closed this task as Resolved.Sep 24 2015, 10:08 PM

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 9:01 PM

Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:48 AM

• DStrine added a project: Unplanned-Sprint-Work.Sep 30 2015, 8:31 PM

• DStrine moved this task from Closed Sprint Work Q1 1516 to Closed Sprint Work Completed in Q2 1516 on the Fundraising-Backlog board.Oct 5 2015, 5:26 PM

• DStrine moved this task from Closed Sprint Work Completed in Q2 1516 to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.

• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:39 PM