Page MenuHomePhabricator
Create Task
Maniphest T112942

[Regression] PHP version check broken in load.php and api.php
Closed, ResolvedPublic
Actions

Description

According to https://3v4l.org/giQf8, PHP versions older than 5.3.0 will throw a syntax error instead of showing the normal error message.

Caused by rMW636cc420c61b: resourceloader: Make ResourceLoader logger aware.

Details

SubjectRepoBranchLines +/-
Remove PHP detection from entry points other than index.phpmediawiki/coremaster+0 -10
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Sep 17 2015, 7:34 PM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added projects: Regression, MediaWiki-ResourceLoader.
Legoktm added subscribers: Legoktm, Krinkle.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2015, 7:34 PM
Legoktm set Security to None.Sep 17 2015, 7:34 PM
Legoktm added a subscriber: PleaseStand.
Krinkle added a comment.Nov 12 2015, 10:31 PM

I think we should remove the PHP<5.3 detection from entry points other than index.php. When the wiki is broken to the extend that the php runtime isn't supported, index.php will render a basic error page. The other entry points don't need to support this I think.

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 12 2015, 10:31 PM
Krinkle triaged this task as Low priority.Nov 12 2015, 10:31 PM
Krinkle moved this task from Inbox to Confirmed Problem on the MediaWiki-ResourceLoader board.
Krinkle renamed this task from [Regression] load.php no longer parses on old PHP versions to [Regression] PHP version check broken in load.php and api.php.Nov 12 2015, 10:35 PM
gerritbot subscribed.Nov 12 2015, 10:36 PM

Change 252856 had a related patch set uploaded (by Krinkle):
Remove PHP detection from entry points other than index.php

https://gerrit.wikimedia.org/r/252856

gerritbot added a project: Patch-For-Review.Nov 12 2015, 10:36 PM
gerritbot added a comment.Nov 13 2015, 1:01 AM

Change 252856 merged by jenkins-bot:
Remove PHP detection from entry points other than index.php

https://gerrit.wikimedia.org/r/252856

Krinkle closed this task as Resolved.Nov 13 2015, 1:12 AM
Krinkle claimed this task.
Krinkle moved this task from Confirmed Problem to Assigned on the MediaWiki-ResourceLoader board.
ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-11-17_(1.27.0-wmf.7)).Nov 13 2015, 2:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL