Page MenuHomePhabricator
Create Task
Maniphest T112960

CX trend percentage will be NaN if delta is zero
Closed, ResolvedPublic
Actions

Description

In getTrend in CXStats.prototype.renderHighlights the trend calculation can be a division by zero. When this happens, NaN% is shown.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Prevent NaN in the trend in CXStatsmediawiki/extensions/ContentTranslationmaster+13 -6
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Sep 17 2015, 8:30 PM
Amire80 raised the priority of this task from to Medium.
Amire80 updated the task description. (Show Details)
Amire80 added projects: ContentTranslation, ContentTranslation-Analytics.
Amire80 subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2015, 8:30 PM
Amire80 claimed this task.Sep 18 2015, 12:48 PM
Amire80 moved this task from Needs Triage to CX6 on the ContentTranslation board.
Amire80 added projects: LE-CX6-Sprint 4, ContentTranslation-Release6, good first task.
Amire80 set Security to None.
gerritbot subscribed.Sep 18 2015, 12:50 PM

Change 239364 had a related patch set uploaded (by Amire80):
Prevent NaN in the trend in CXStats

https://gerrit.wikimedia.org/r/239364

gerritbot added a project: Patch-For-Review.Sep 18 2015, 12:50 PM
gerritbot added a comment.Sep 18 2015, 8:25 PM

Change 239364 merged by Nikerabbit:
Prevent NaN in the trend in CXStats

https://gerrit.wikimedia.org/r/239364

Amire80 mentioned this in rMEXTb11c8255b2e7: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Sep 18 2015, 8:25 PM
Amire80 mentioned this in rECTX9471960f7bf3: Prevent NaN in the trend in CXStats.
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 18 2015, 9:00 PM
Amire80 moved this task from Backlog to Done on the LE-CX6-Sprint 4 board.Sep 20 2015, 9:57 AM
Liuxinyu970226 subscribed.Sep 30 2015, 10:15 AM
Amire80 closed this task as Resolved.Oct 1 2015, 5:49 PM
Amire80 removed a project: Patch-For-Review.
Liuxinyu970226 unsubscribed.Oct 2 2015, 9:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits