As uncovered by @XenoRyet, banners don't show up on IE9 platform at all!
Further digging: they're also not showing up on IE8!
From initial tests: it may not be the same issue on both.
Together these browsers represent 2.65% of our users.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Stronger check for Object.defineProperty, to handle IE8 | mediawiki/extensions/CentralNotice | master | +10 -8 |
Event Timeline
Comment Actions
Down to a 2.11% share in the latest stats: https://docs.google.com/spreadsheets/d/1n9FhSqcBGM9iKXrlHsP0EZI0gU89Rmz5m51uglUGVjs/edit#gid=0
Comment Actions
Update:
- Things are working fine again in IE9. I think we can assume it was something that wasn't ours, that broke and got fixed...
- Banners are failing in IE8 due to our test for the availability of Object.defineProperty not working right in IE8. In that browser, defineProperty works only for DOM objects.
Comment Actions
Change 250896 had a related patch set uploaded (by AndyRussG):
Stronger check for Object.defineProperty, to handle IE8
Comment Actions
Change 250896 merged by Ejegg:
Stronger check for Object.defineProperty, to handle IE8
Comment Actions
Our fix for this was deployed. Locally, banners work on IE8 for me. They also work on the beta cluster.
However, on production , they still don't! I'm still getting the same "TypeError: Object doesn't support this property or methodTypeError: Object doesn't support this property or method" error. While sometimes the message says it comes from ext.centralNotice.startUp, other times it says the error is from "module-execute".
In view of the above, it seems likely that this not the fault of CentralNotice. We could investigate further...
Comment Actions
Just to note, it was announced that MediaWiki's JS support for IE8 is being dropped in January anyway. https://lists.wikimedia.org/pipermail/wikitech-l/2015-November/083964.html
Comment Actions
Thanks @Pcoombe! Weeee... excellent timing. I'd definitely suggest we close this card then. :)
Comment Actions
Marked "Resolved" rather than "Declined" since it appears likely that we fixed the only CentralNotice-related issue (not investigating to check for sure, though).