Page MenuHomePhabricator

[Task] Remove use of RawMode in WikibaseQualityExternalValidation
Closed, ResolvedPublic

Description

RawMode is now deprecated in core and causes warnings during tests that cause the tests to fail.

and we don't want to use RawMode anyway.

https://integration.wikimedia.org/ci/job/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/288/console

10:42:04 There was 1 error:
10:42:04 
10:42:04 1) WikibaseQuality\ExternalValidation\Tests\Api\RunCrossCheckTest::testExecuteWholeItem
10:42:04 Use of ApiResult::getIsRawMode was deprecated in MediaWiki 1.25. [Called from WikibaseQuality\ExternalValidation\Api\RunCrossCheck::writeResultOutput in /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/extensions/WikibaseQualityExternalValidation/api/RunCrossCheck.php at line 174]
10:42:04 
10:42:04 /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/includes/debug/MWDebug.php:300
10:42:04 /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/includes/debug/MWDebug.php:233
10:42:04 /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/includes/GlobalFunctions.php:1195
10:42:04 /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/includes/api/ApiResult.php:1222
10:42:04 /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/extensions/WikibaseQualityExternalValidation/api/RunCrossCheck.php:174
10:42:04 /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/extensions/WikibaseQualityExternalValidation/api/RunCrossCheck.php:140
10:42:04 /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/includes/api/ApiMain.php:1233
10:42:04 /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/includes/api/ApiMain.php:403
10:42:04 /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/tests/phpunit/includes/api/ApiTestCase.php:116
10:42:04 /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/extensions/WikibaseQualityExternalValidation/tests/phpunit/Api/RunCrossCheckTest.php:202
10:42:04 /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/tests/phpunit/MediaWikiTestCase.php:131
10:42:04 
10:42:04 --
10:42:04 
10:42:04 
10:42:04 There were 2 failures:
10:42:04 
10:42:04 1) WikibaseQuality\ExternalValidation\Tests\Api\RunCrossCheckTest::testExecutePropertyFilter
10:42:04 Failed asserting that an array has the key 'Q2'.
10:42:04 
10:42:04 /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/extensions/WikibaseQualityExternalValidation/tests/phpunit/Api/RunCrossCheckTest.php:221
10:42:04 /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/tests/phpunit/MediaWikiTestCase.php:131
10:42:04 
10:42:04 2) WikibaseQuality\ExternalValidation\Tests\Api\RunCrossCheckTest::testExecuteSingleClaim
10:42:04 Failed asserting that an array has the key 'Q2'.
10:42:04 
10:42:04 /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/extensions/WikibaseQualityExternalValidation/tests/phpunit/Api/RunCrossCheckTest.php:244
10:42:04 /mnt/jenkins-workspace/workspace/mwext-WikibaseQualityExternalValidation-repo-tests-mysql-hhvm/src/tests/phpunit/MediaWikiTestCase.php:131

Event Timeline

aude raised the priority of this task from to High.
aude updated the task description. (Show Details)
aude added subscribers: aude, Addshore.
JanZerebecki updated the task description. (Show Details)
JanZerebecki renamed this task from Remove use of RawMode in WikibaseQualityExternalValidation to [Task] Remove use of RawMode in WikibaseQualityExternalValidation.Sep 18 2015, 12:47 PM
JanZerebecki moved this task from incoming to in progress on the Wikidata board.

Change 241062 had a related patch set uploaded (by Daniel Kinzler):
Test JSON and XML output

https://gerrit.wikimedia.org/r/241062

Change 241073 had a related patch set uploaded (by Daniel Kinzler):
Remove usages of ApiResult::getIsRawMode

https://gerrit.wikimedia.org/r/241073

Change 241062 merged by JanZerebecki:
Test JSON and XML output

https://gerrit.wikimedia.org/r/241062

Change 241073 merged by jenkins-bot:
Remove usages of ApiResult::getIsRawMode

https://gerrit.wikimedia.org/r/241073

JanZerebecki claimed this task.
JanZerebecki moved this task from Backlog to Done on the Wikidata-Sprint-2015-09-15 board.

Change 268807 had a related patch set uploaded (by Paladox):
Test JSON and XML output

https://gerrit.wikimedia.org/r/268807

Change 268807 abandoned by Paladox:
Test JSON and XML output

https://gerrit.wikimedia.org/r/268807