Page MenuHomePhabricator

Documentation for "raw" attribute doesn't match the logic of the code
Closed, ResolvedPublic

Description

The documentation states that the "raw" attribute should be set to "0" or "1", with "1" meaning that the score is a full LilyPond file. On the other hand the code just checks whether the "raw" attribute exists. This means that if raw="0" the score is treated as a full LilyPond file.

Event Timeline

Tchanders raised the priority of this task from to Needs Triage.
Tchanders updated the task description. (Show Details)
Tchanders added a subscriber: Tchanders.
Ebe123 added a subscriber: Ebe123.

The current use of <score tags indicate that the attributes are merely added in most cases, and so I've just updated the documentation without touching the logic.

Change 370305 had a related patch set uploaded (by Ebe123; owner: Ebe123):
[mediawiki/extensions/Score@master] Update documentation

https://gerrit.wikimedia.org/r/370305

Change 370305 merged by jenkins-bot:
[mediawiki/extensions/Score@master] Update documentation

https://gerrit.wikimedia.org/r/370305

Patch merged, updating the documentation while fixing incorrect parts and making the other boolean parameters consistent with raw.