Page MenuHomePhabricator
Create Task
Maniphest T113122

maps: support wikivoyages in incubator
Closed, ResolvedPublic
Actions

Description

See also this.

Wikivoyages with their own domain are supported, but wikivoyages in the incubator (which is not yet ready for own domain) are not getting the support of new tool, which is bad.

Details

SubjectRepoBranchLines +/-
varnish: add 'incubator' to maps-frontend regexoperations/puppetproduction+1 -1
Added incubator.wikimedia.org to maps referer testoperations/puppetproduction+1 -1
Customize query in gerrit

Related Objects

Event Timeline

revi created this task.Sep 19 2015, 3:00 AM
revi raised the priority of this task from to Needs Triage.
revi updated the task description. (Show Details)
revi added projects: Maps, acl*sre-team.
revi added subscribers: revi, Aklapper.
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptSep 19 2015, 3:00 AM
Restricted Application added a subscriber: Matanya. · View Herald Transcript
Dzahn removed a project: acl*sre-team.Sep 19 2015, 6:08 AM
Dzahn set Security to None.
Dzahn added a project: acl*sre-team.Sep 19 2015, 6:11 AM
Dzahn added subscribers: • Tfinc, Dzahn.

@Tfinc said:

//Operations will need to update the referrer in Varnish ERB. Similar to

https://gerrit.wikimedia.org/r/#/c/239279///

Dzahn renamed this task from Support incubator to maps: support wikivoyages in incubator.Sep 19 2015, 6:16 AM

@revi said

It is sad that incubator.wikimedia.org is not included. (Wikivoyages not
ready for their own wikis resides on this domain under prefix Wy/**, so
Korean one becomes [[Wy/ko]].)

Dzahn added a project: Traffic.Oct 6 2015, 10:36 PM

added project Traffic per "need to update the referrer in Varnish ERB"

gerritbot subscribed.Oct 6 2015, 10:40 PM

Change 244070 had a related patch set uploaded (by Dzahn):
varnish: add 'incubator' to maps-frontend regex

https://gerrit.wikimedia.org/r/244070

gerritbot added a project: Patch-For-Review.Oct 6 2015, 10:40 PM
gerritbot added a comment.Oct 6 2015, 10:44 PM

Change 244072 had a related patch set uploaded (by Yurik):
Added incubator.wikimedia.org to maps referer test

https://gerrit.wikimedia.org/r/244072

Yurik subscribed.Oct 6 2015, 10:46 PM

Lol, @Dzahn, I added exactly the same patch as you 4 minutes after :))
Closing mine.

gerritbot added a comment.Oct 6 2015, 10:48 PM

Change 244072 abandoned by Yurik:
Added incubator.wikimedia.org to maps referer test

Reason:
This is an identical dup of https://gerrit.wikimedia.org/r/#/c/244070/

https://gerrit.wikimedia.org/r/244072

Dzahn triaged this task as Medium priority.Oct 6 2015, 10:55 PM
gerritbot added a comment.Oct 7 2015, 8:02 AM

Change 244070 merged by Alexandros Kosiaris:
varnish: add 'incubator' to maps-frontend regex

https://gerrit.wikimedia.org/r/244070

akosiaris mentioned this in rOPUP42154ed81042: varnish: add 'incubator' to maps-frontend regex.Oct 7 2015, 8:02 AM
akosiaris subscribed.Oct 7 2015, 8:04 AM

Change merged, anything else to do here or is this ready to be resolved ?

Yurik closed this task as Resolved.Oct 7 2015, 10:49 AM
Yurik claimed this task.
revi removed a project: Patch-For-Review.Oct 7 2015, 3:00 PM
BBlack moved this task from Backlog to Done on the Traffic board.Oct 26 2015, 4:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL