Page MenuHomePhabricator

ve.ce.Surface: refactor afterDocumentKeyDown and postponed code in handleLinear*Key afterOne handlers
Open, MediumPublic8 Estimated Story Points

Description

Post-keydown fixups are coded in different places:

  • afterDocumentKeyDown
  • an afterOne handlers in handleLinearArrowKey
  • two afterOne handlers in handleLinearDelete

This is hard to read and understand - we should refactor all this into one place, or at least make it clearer.

See also comments in T91518 .

Event Timeline

dchan created this task.Sep 21 2015, 8:16 PM
dchan claimed this task.
dchan raised the priority of this task from to Medium.
dchan updated the task description. (Show Details)
dchan added a subscriber: dchan.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2015, 8:16 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
Aklapper removed dchan as the assignee of this task.Jun 19 2020, 4:24 PM

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)