Currently, if I select suggestion A, the new translation dialog opens with the text cursor in the source field (which results on the autocompletion article list to be displayed). Since it is unlikely that the user will change the article to translate right after selecting the suggestion, it is better to move to the input to the next field.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T76456 Language Engineering tracker of trackers (tracking) | |||
| Open | None | T76448 [Epic] ContentTranslation - Entry Points | |||
| Open | None | T87867 Experiment ways to get more users to translate articles (tracking) | |||
| Open | None | T96134 Entry Point: Show an entry point to ContentTranslation at an empty page in action=view | |||
| Duplicate | None | T90224 Allow anonymous users to translate | |||
| Duplicate | None | T90186 Entry point: change target language from gray links panel | |||
| Open | None | T90185 Entry point: Change source language from gray link panel | |||
| Resolved | Amire80 | T90172 Suggest interlanguage translation opportunity based on browser Accept-Language | |||
| Open | None | T90162 Entry point: New translation from Wikidata | |||
| Open | None | T76457 [Epic] ContentTranslation - Translation Dashboard | |||
| Open | None | T87439 [Tracking] Suggest articles to translate from the dashboard | |||
| Resolved | Amire80 | T113332 When opening the dialog from a suggestion, the focus should be in the target title field |
Event Timeline
Comment Actions
Change 248864 had a related patch set uploaded (by Amire80):
WIP: Focus on the target field when opening a suggestion
Comment Actions
@Amire80, what do you think about this simple patch?
diff --git a/modules/source/ext.cx.source.selector.js b/modules/source/ext.cx.source.selector.js index 63d4dcb..541b092 100644 --- a/modules/source/ext.cx.source.selector.js +++ b/modules/source/ext.cx.source.selector.js @@ -93,11 +93,11 @@ } if ( this.options.sourceTitle ) { - this.$sourceTitleInput.val( this.options.sourceTitle ).trigger( 'input' ); + this.$sourceTitleInput.val( this.options.sourceTitle ); } if ( this.options.targetTitle ) { - this.$targetTitleInput.val( this.options.targetTitle ).trigger( 'input' ); + this.$targetTitleInput.val( this.options.targetTitle ); } // If all of the values are already present, @@ -627,7 +627,11 @@ this.showAsDialog(); } - this.$sourceTitleInput.focus(); + if ( !this.options.sourceTitle ) { + this.$sourceTitleInput.focus(); + } else { + this.$targetTitleInput.focus(); + } }; /**
Comment Actions
Change 248864 abandoned by Amire80:
Focus on the target field when opening a suggestion
Reason:
Will be done differently.
Comment Actions
Change 250509 had a related patch set uploaded (by Amire80):
In the page selector, focus on the target title if the source title is prefilled
Comment Actions
Change 250509 merged by jenkins-bot:
In the page selector, focus on the target title if the source title is prefilled