Maniphest T113357

Remove use of UserRights hook when UserGroupsChanged hook is available
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Anomie
	Sep 22 2015, 2:28 PM

Tags

Referenced Files

None

Subscribers

Description

As of https://gerrit.wikimedia.org/r/#/c/236043/ the UserRights hook is deprecated in favor of the new UserGroupsChanged hook.

The differences from UserRights to UserGroupsChanged are:

$user is passed by value, not by reference.
UserGroupsChanged is called for autopromote-once groups (e.g. 'autopatrolled' on Wikivoyage or 'uploader' on ruwiki).

Details

	Subject	Repo	Branch	Lines +/-
	Use UserGroupsChanged hook instead of deprecated UserRights hook	mediawiki/extensions/Echo	master	+24 -10

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Legoktm	T113358 Pass $deprecatedVersion parameter to the invocation of the UserRights hook
		Resolved		Legoktm	T113357 Remove use of UserRights hook when UserGroupsChanged hook is available

Event Timeline

Anomie created this task.Sep 22 2015, 2:28 PM

Anomie raised the priority of this task from to Needs Triage.

Anomie updated the task description. (Show Details)

Anomie added projects: Notifications, Technical-Debt.

Anomie subscribed.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 22 2015, 2:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Anomie added a parent task: T113358: Pass $deprecatedVersion parameter to the invocation of the UserRights hook.Sep 22 2015, 2:28 PM

Change 240144 had a related patch set uploaded (by Legoktm):
Use UserGroupsChanged hook instead of deprecated UserRights hook

https://gerrit.wikimedia.org/r/240144

gerritbot added a project: Patch-For-Review.Sep 22 2015, 6:17 PM

Change 240144 merged by jenkins-bot:
Use UserGroupsChanged hook instead of deprecated UserRights hook

https://gerrit.wikimedia.org/r/240144

Legoktm mentioned this in rECHO073ade0a7721: Use UserGroupsChanged hook instead of deprecated UserRights hook.Sep 22 2015, 6:24 PM

Diffusion mentioned this in rMEXT00c2eb94bd64: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Sep 22 2015, 6:24 PM

Legoktm closed this task as Resolved.Sep 22 2015, 6:28 PM

Legoktm claimed this task.

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 7:57 PM

Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 7:58 PM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM