Page MenuHomePhabricator

HHVM timeouts mean videoscaling can't clean locally transcoded files from the filesystem
Closed, ResolvedPublic

Description

@MoritzMuehlenhoff found out this morning that mw1152 had /tmp full of already transcoded files. It seems like we don't clean them up upon job execution, or something like that.

I could set up a cronjob to clean them but I think we should just take care of removing them once the files are copied to swift.

Event Timeline

Joe created this task.Sep 23 2015, 6:14 AM
Joe raised the priority of this task from to High.
Joe updated the task description. (Show Details)
Joe added subscribers: Joe, brion, MoritzMuehlenhoff.
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptSep 23 2015, 6:14 AM
brion added a comment.Sep 23 2015, 4:58 PM

Are these from completed jobs or jobs that timed out during the shell-out, halting HHVM PHP execution before it got a chance to clean up its files?

brion added a comment.Sep 23 2015, 6:00 PM

I notice a lot of the webms have 2-pass log files alongside them, so definitely looks like jobs got shut down while in progress, leaving no chance for the PHP code to clean up the file. The code looks like it correctly purges when done, as long as it has a chance to run.

brion renamed this task from videoscaling doesn't clean locally transcoded files from the filesystem to HHVM timeouts mean videoscaling can't clean locally transcoded files from the filesystem.Sep 23 2015, 6:01 PM
brion set Security to None.
Joe closed this task as Resolved.Sep 29 2015, 12:46 PM
Joe claimed this task.