Page MenuHomePhabricator
Create Task
Maniphest T113511

Category media styles broken in 1.26wmf24
Closed, ResolvedPublic
Actions

Description

The category design (for files in cat) is broken since 18:54 <twentyafterfour@tin> rebuilt wikiversions.cdb and synchronized wikiversions files: group1 wikis to 1.26wmf24

See https://commons.wikimedia.org/wiki/Category:Tests or just pick up a random cat

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Load module mediawiki.page.gallery.styles for all ImageGalleriesmediawiki/coreREL1_26+1 -1
Load module mediawiki.page.gallery.styles for all ImageGalleriesmediawiki/coremaster+1 -1
Load gallery styles on Category pages, toomediawiki/coremaster+4 -0
Revert "Do not double load gallery styles now cache has expired"mediawiki/coremaster+4 -0
Revert "Do not double load gallery styles now cache has expired"mediawiki/corewmf/1.26wmf24+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Steinsplitter created this task.Sep 23 2015, 7:21 PM
Steinsplitter raised the priority of this task from to High.
Steinsplitter updated the task description. (Show Details)
Steinsplitter added a project: acl*sre-team.
Steinsplitter added subscribers: Steinsplitter, ori.
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptSep 23 2015, 7:21 PM
Steinsplitter updated the task description. (Show Details)Sep 23 2015, 7:22 PM
Steinsplitter added a project: Commons.
Steinsplitter set Security to None.
Steinsplitter moved this task from Incoming to Backlog on the Commons board.
Krenair edited projects, added MediaWiki-Categories; removed acl*sre-team.Sep 23 2015, 7:23 PM
Krenair subscribed.
ori added a subscriber: Jdlrobson.Sep 23 2015, 7:26 PM

The gallery styles are not getting loaded. I think this is related to https://gerrit.wikimedia.org/r/#/c/234592/ . Ping @Jdlrobson.

ori raised the priority of this task from High to Unbreak Now!.Sep 23 2015, 7:29 PM
greg subscribed.Sep 23 2015, 7:30 PM

Screenshot of current situation:

Selection_035.png (1×1 px, 82 KB)

greg assigned this task to Jdlrobson.Sep 23 2015, 7:30 PM
Krenair renamed this task from Category design broken after 1.26wmf24 to Category media styles broken in 1.26wmf24.Sep 23 2015, 7:30 PM
Krenair removed Jdlrobson as the assignee of this task.
Krenair assigned this task to Jdlrobson.
gerritbot subscribed.Sep 23 2015, 7:32 PM

Change 240505 had a related patch set uploaded (by Ori.livneh):
Revert "Do not double load gallery styles now cache has expired"

https://gerrit.wikimedia.org/r/240505

gerritbot added a project: Patch-For-Review.Sep 23 2015, 7:32 PM

Change 240511 had a related patch set uploaded (by Ori.livneh):
Revert "Do not double load gallery styles now cache has expired"

https://gerrit.wikimedia.org/r/240511

gerritbot added a comment.Sep 23 2015, 7:36 PM

Change 240511 merged by Ori.livneh:
Revert "Do not double load gallery styles now cache has expired"

https://gerrit.wikimedia.org/r/240511

Florian subscribed.Sep 23 2015, 7:40 PM
gerritbot added a comment.Sep 23 2015, 7:41 PM

Change 240560 had a related patch set uploaded (by Umherirrender):
Load module mediawiki.page.gallery.styles for all ImageGalleries

https://gerrit.wikimedia.org/r/240560

Florian claimed this task.Sep 23 2015, 7:41 PM
ori lowered the priority of this task from Unbreak Now! to Medium.Sep 23 2015, 7:44 PM
gerritbot added a comment.Sep 23 2015, 7:49 PM

Change 240563 had a related patch set uploaded (by Florianschmidtwelzow):
Load gallery styles on Category pages, too

https://gerrit.wikimedia.org/r/240563

ori mentioned this in rMWdbfe0e465de1: Revert "Do not double load gallery styles now cache has expired".Sep 23 2015, 7:53 PM
Jdlrobson added a comment.Sep 23 2015, 7:57 PM

Thanks for taking care of this. So the big question I now have is why are category pages not using the gallery tag?

gerritbot added a comment.Sep 23 2015, 8:03 PM

Change 240505 merged by jenkins-bot:
Revert "Do not double load gallery styles now cache has expired"

https://gerrit.wikimedia.org/r/240505

ori mentioned this in rMW4a9aab29c1ba: Revert "Do not double load gallery styles now cache has expired".Sep 23 2015, 8:03 PM
Keegan subscribed.Sep 23 2015, 8:06 PM
In T113511#1667631, @Jdlrobson wrote:

Thanks for taking care of this. So the big question I now have is why are category pages not using the gallery tag?

I presume because the category system predates the gallery tag, and the two were never fully reconciled.

Jdlrobson added a comment.Sep 23 2015, 8:15 PM

Thanks @Keegan opened T113522

Jdlrobson added a parent task: T110709: Stop double loading mediawiki.page.gallery.styles.Sep 23 2015, 10:08 PM
gerritbot added a comment.Sep 24 2015, 10:51 AM

Change 240563 abandoned by Florianschmidtwelzow:
Load gallery styles on Category pages, too

Reason:
See I32697c2c65824d7622c.

https://gerrit.wikimedia.org/r/240563

Krinkle added a project: Regression.Sep 24 2015, 4:42 PM
gerritbot added a comment.Sep 24 2015, 6:22 PM

Change 240560 merged by jenkins-bot:
Load module mediawiki.page.gallery.styles for all ImageGalleries

https://gerrit.wikimedia.org/r/240560

Umherirrender mentioned this in rMW27700d276f96: Load module mediawiki.page.gallery.styles for all ImageGalleries.Sep 24 2015, 6:22 PM
Umherirrender closed this task as Resolved.Sep 24 2015, 8:02 PM
Umherirrender subscribed.

Regression fixed by adding the necessary styles for all image galleries (including parser tags, category page and special pages)

Florian closed subtask T113522: Reconcile category and gallery code to be generated via the same mechanism as Invalid.Sep 24 2015, 8:10 PM
Jdlrobson added a comment.Sep 24 2015, 9:40 PM

Thanks @Umherirrender !

ReleaseTaggerBot added projects: WMF-deploy-2015-09-22_(1.26wmf24), MW-1.27-release, MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 8:02 PM
greg edited projects, added MW-1.27-release-notes; removed MW-1.27-release.Sep 29 2015, 10:27 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:48 AM
gerritbot added a comment.Oct 6 2015, 8:00 PM

Change 244011 had a related patch set uploaded (by Umherirrender):
Load module mediawiki.page.gallery.styles for all ImageGalleries

https://gerrit.wikimedia.org/r/244011

matmarex edited projects, added MW-1.26-release; removed Patch-For-Review.Oct 7 2015, 3:02 PM
gerritbot added a comment.Oct 7 2015, 3:12 PM

Change 244011 merged by jenkins-bot:
Load module mediawiki.page.gallery.styles for all ImageGalleries

https://gerrit.wikimedia.org/r/244011

Umherirrender mentioned this in rMWa98db209c4d1: Load module mediawiki.page.gallery.styles for all ImageGalleries.Oct 7 2015, 3:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits