Page MenuHomePhabricator

Category media styles broken in 1.26wmf24
Closed, ResolvedPublic

Description

The category design (for files in cat) is broken since 18:54 <twentyafterfour@tin> rebuilt wikiversions.cdb and synchronized wikiversions files: group1 wikis to 1.26wmf24

See https://commons.wikimedia.org/wiki/Category:Tests or just pick up a random cat

Event Timeline

Steinsplitter raised the priority of this task from to High.
Steinsplitter updated the task description. (Show Details)
Steinsplitter added a project: acl*sre-team.
Steinsplitter added subscribers: Steinsplitter, ori.
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptSep 23 2015, 7:21 PM
Steinsplitter added a project: Commons.
Steinsplitter set Security to None.
Steinsplitter moved this task from Incoming to Backlog on the Commons board.
Krenair added a subscriber: Krenair.
ori added a subscriber: Jdlrobson.Sep 23 2015, 7:26 PM

The gallery styles are not getting loaded. I think this is related to https://gerrit.wikimedia.org/r/#/c/234592/ . Ping @Jdlrobson.

ori raised the priority of this task from High to Unbreak Now!.Sep 23 2015, 7:29 PM
greg added a subscriber: greg.Sep 23 2015, 7:30 PM

Screenshot of current situation:

greg assigned this task to Jdlrobson.Sep 23 2015, 7:30 PM
Krenair renamed this task from Category design broken after 1.26wmf24 to Category media styles broken in 1.26wmf24.Sep 23 2015, 7:30 PM
Krenair removed Jdlrobson as the assignee of this task.
Krenair assigned this task to Jdlrobson.

Change 240505 had a related patch set uploaded (by Ori.livneh):
Revert "Do not double load gallery styles now cache has expired"

https://gerrit.wikimedia.org/r/240505

Change 240511 had a related patch set uploaded (by Ori.livneh):
Revert "Do not double load gallery styles now cache has expired"

https://gerrit.wikimedia.org/r/240511

Change 240511 merged by Ori.livneh:
Revert "Do not double load gallery styles now cache has expired"

https://gerrit.wikimedia.org/r/240511

Change 240560 had a related patch set uploaded (by Umherirrender):
Load module mediawiki.page.gallery.styles for all ImageGalleries

https://gerrit.wikimedia.org/r/240560

Florian claimed this task.Sep 23 2015, 7:41 PM
ori lowered the priority of this task from Unbreak Now! to Medium.Sep 23 2015, 7:44 PM

Change 240563 had a related patch set uploaded (by Florianschmidtwelzow):
Load gallery styles on Category pages, too

https://gerrit.wikimedia.org/r/240563

Thanks for taking care of this. So the big question I now have is why are category pages not using the gallery tag?

Change 240505 merged by jenkins-bot:
Revert "Do not double load gallery styles now cache has expired"

https://gerrit.wikimedia.org/r/240505

Keegan added a subscriber: Keegan.Sep 23 2015, 8:06 PM

Thanks for taking care of this. So the big question I now have is why are category pages not using the gallery tag?

I presume because the category system predates the gallery tag, and the two were never fully reconciled.

Change 240563 abandoned by Florianschmidtwelzow:
Load gallery styles on Category pages, too

Reason:
See I32697c2c65824d7622c.

https://gerrit.wikimedia.org/r/240563

Change 240560 merged by jenkins-bot:
Load module mediawiki.page.gallery.styles for all ImageGalleries

https://gerrit.wikimedia.org/r/240560

Umherirrender closed this task as Resolved.Sep 24 2015, 8:02 PM
Umherirrender added a subscriber: Umherirrender.

Regression fixed by adding the necessary styles for all image galleries (including parser tags, category page and special pages)

Change 244011 had a related patch set uploaded (by Umherirrender):
Load module mediawiki.page.gallery.styles for all ImageGalleries

https://gerrit.wikimedia.org/r/244011

Change 244011 merged by jenkins-bot:
Load module mediawiki.page.gallery.styles for all ImageGalleries

https://gerrit.wikimedia.org/r/244011