Page MenuHomePhabricator
Create Task
Maniphest T113544

Revert to old web view lead image presentation
Closed, InvalidPublic
Actions

Description

With native card being tabled for now, we'll need to again show the lead image in the web view.

-Bring back old html lead image. (Note: there was large variety of behaviors the old html lead image code supported such as proper landscape and tablet behavior. Just revert to this for now so we don't have to re-address all of these issues pre-5.0 beta)
-This will be super easy to bring back in an isolated fashion using a custom NSURLProtocol - I have a proof of concept.

Related Objects

Event Timeline

Mhurd created this task.Sep 23 2015, 10:17 PM
Mhurd raised the priority of this task from to Needs Triage.
Mhurd updated the task description. (Show Details)
Mhurd added a project: Wikipedia-iOS-App-Backlog.
Mhurd moved this task to Needs Triage on the Wikipedia-iOS-App-Backlog board.
Mhurd subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2015, 10:17 PM
Mhurd updated the task description. (Show Details)Sep 23 2015, 10:19 PM
Mhurd set Security to None.
Mhurd updated the task description. (Show Details)
• BGerstle-WMF subscribed.Sep 23 2015, 10:25 PM

We will need to also make sure: the lead image is high-res & face-detected. IIRC there was some side-effect stuff going on that caused the webVC to force the lead image.

Mhurd updated the task description. (Show Details)Sep 23 2015, 10:33 PM

@BGerstle-WMF "caused the webVC to force the lead image" ... to what?

Mhurd added a comment.Sep 23 2015, 10:36 PM

Face detection offsets worked with the both the original native lead image overlay and the html lead image which replaced it.

• BGerstle-WMF added a comment.Sep 23 2015, 10:38 PM

Detecting if we fetched the lead image and replacing the placeholder.

Mhurd added a comment.Sep 23 2015, 10:38 PM

That all worked.

• BGerstle-WMF added a comment.Sep 23 2015, 10:40 PM

Right, but that was before we revamped image caching, which no longer posts that notification. I'm just saying we'll have to hook that back up.

• KHammerstein mentioned this in T113674: Update visual style of article web view.Sep 24 2015, 10:11 PM
• JMinor triaged this task as Medium priority.Oct 2 2015, 4:06 AM
• JMinor moved this task from Needs Triage to Needs Estimation on the Wikipedia-iOS-App-Backlog board.
• JMinor subscribed.

See also T113674.

• JMinor added a project: iOS-app-v5-alpha.Oct 2 2015, 6:05 PM
• BGerstle-WMF closed this task as Invalid.Oct 2 2015, 6:13 PM
• BGerstle-WMF claimed this task.

Already done as part of T113773. Still need to decide on header gallery.

• BGerstle-WMF moved this task from Needs Estimation to Resolved/Invalid/Declined/Legacy on the Wikipedia-iOS-App-Backlog board.Oct 27 2015, 6:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL