Page MenuHomePhabricator
Create Task
Maniphest T113647

Search for templates with no response fatals, doesn't ever tell the user it's given up
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:
1.Go to Insert>Template
2.In the search text box type something like "Citation is Needed"

Observed Result:
The search progress bar keeps on running and "TypeError: response.query is undefined" appears in the console

Screen Shot 2015-09-24 at 2.04.02 PM.png (671×1 px, 272 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+1 -1Use ve.setProp to set new pages list in MWTemplateTitleInputWidget#getLookupRequest
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Sep 24 2015, 7:10 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen added a subscriber: Ryasmeen.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2015, 7:10 PM
Jdforrester-WMF renamed this task from "TypeError: response.query is undefined" appears in the console and search progress bar continues infinitely while searching for a template name which does not have any match to Search for templates with no response fatals, doesn't ever tell the user it's given up.Sep 24 2015, 7:18 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF added a project: VisualEditor-MediaWiki-Templates.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
Jdforrester-WMF added a subscriber: Krenair.
gerritbot added a subscriber: gerritbot.Sep 24 2015, 9:36 PM

Change 240904 had a related patch set uploaded (by Alex Monk):
Use ve.setProp to set new pages list in MWTemplateTitleInputWidget#getLookupRequest

https://gerrit.wikimedia.org/r/240904

gerritbot added a project: Patch-For-Review.Sep 24 2015, 9:36 PM
Krenair claimed this task.Sep 24 2015, 9:37 PM
gerritbot added a comment.Oct 4 2015, 7:54 PM

Change 240904 merged by jenkins-bot:
Use ve.setProp to set new pages list in MWTemplateTitleInputWidget#getLookupRequest

https://gerrit.wikimedia.org/r/240904

Krenair mentioned this in rEVED0fb38cc82461: Use ve.setProp to set new pages list in….Oct 4 2015, 7:54 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Oct 4 2015, 8:00 PM
Krenair closed this task as Resolved.Oct 4 2015, 8:27 PM
Ryasmeen added a project: Verified.Oct 5 2015, 9:23 PM
Jdforrester-WMF moved this task from Freezer to TR1: Releases on the VisualEditor board.Oct 21 2015, 10:12 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL