Page MenuHomePhabricator
Create Task
Maniphest T113650

ContentTranslation causes "TypeError: $.uls is undefined" since 1.26wmf24
Closed, ResolvedPublic
Actions

Description

When I access a random page on ptwiki I get this:

{
	"errorMessage": "TypeError: $.uls is undefined",
	"url": "https://pt.wikipedia.org/static/1.26wmf24/extensions/ContentTranslation/modules/entrypoint/ext.cx.interlanguagelink.js",
	"lineNumber": 56,
	"columnNumber": 1,
	"errorObject": {}
}

This is the line causing the error:

language !== $.uls.data.getAutonym( language );

https://github.com/wikimedia/mediawiki-extensions-ContentTranslation/blob/7d81c24cc02f07d923efca1dd07a69fe6f86f9f2/modules/entrypoint/ext.cx.interlanguagelink.js#L56

Details

SubjectRepoBranchLines +/-
Interlanguage link: Avoid the requirement of jquery.uls.data module on page loadmediawiki/extensions/ContentTranslationwmf/1.27.0-wmf.1+20 -7
Interlanguage link: Avoid the requirement of jquery.uls.data module on page loadmediawiki/extensions/ContentTranslationmaster+20 -7
ext.cx.interlanguagelink: declare dependency on jquery.uls.datamediawiki/extensions/ContentTranslationwmf/1.27.0-wmf.1+1 -0
ext.cx.interlanguagelink: declare dependency on jquery.uls.datamediawiki/extensions/ContentTranslationmaster+1 -0
ext.cx.interlanguagelink: declare dependency on jquery.uls.datamediawiki/extensions/ContentTranslationwmf/1.26wmf24+1 -0
Customize query in gerrit

Related Objects

Event Timeline

He7d3r created this task.Sep 24 2015, 7:48 PM
He7d3r raised the priority of this task from to Needs Triage.
He7d3r updated the task description. (Show Details)
He7d3r subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2015, 7:48 PM
He7d3r added projects: JavaScript, ContentTranslation-CXserver.Sep 24 2015, 7:49 PM
He7d3r set Security to None.
gerritbot subscribed.Sep 24 2015, 7:52 PM

Change 240871 had a related patch set uploaded (by Ori.livneh):
ext.cx.interlanguagelink: declare dependency on jquery.uls.data

https://gerrit.wikimedia.org/r/240871

gerritbot added a project: Patch-For-Review.Sep 24 2015, 7:52 PM

Change 240872 had a related patch set uploaded (by Ori.livneh):
ext.cx.interlanguagelink: declare dependency on jquery.uls.data

https://gerrit.wikimedia.org/r/240872

Nemo_bis edited projects, added ContentTranslation; removed ContentTranslation-CXserver.Sep 24 2015, 7:55 PM
gerritbot added a comment.Sep 24 2015, 7:56 PM

Change 240872 merged by Ori.livneh:
ext.cx.interlanguagelink: declare dependency on jquery.uls.data

https://gerrit.wikimedia.org/r/240872

ori mentioned this in rECTX8559ee614975: ext.cx.interlanguagelink: declare dependency on jquery.uls.data.Sep 24 2015, 7:57 PM
ori mentioned this in rMWd079d5dd7195: Updated mediawiki/core Project: mediawiki/extensions/ContentTranslation….
ori closed this task as Resolved.Sep 24 2015, 7:57 PM
ori claimed this task.
gerritbot added a comment.Sep 25 2015, 3:48 AM

Change 240957 had a related patch set uploaded (by Santhosh):
Interlanguage link: Avoid the requirement of jquery.uls.data module on page load

https://gerrit.wikimedia.org/r/240957

• santhosh mentioned this in T113705: Provide known and valid language code from mw.uls.getAcceptLanguageList() .Sep 25 2015, 9:05 AM
gerritbot added a comment.Sep 29 2015, 4:45 PM

Change 240871 merged by jenkins-bot:
ext.cx.interlanguagelink: declare dependency on jquery.uls.data

https://gerrit.wikimedia.org/r/240871

ori mentioned this in rECTX156fcb652bfa: ext.cx.interlanguagelink: declare dependency on jquery.uls.data.Sep 29 2015, 4:45 PM
Diffusion mentioned this in rMEXTa0c54d0e7e1d: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Sep 29 2015, 4:46 PM
gerritbot added a comment.Sep 29 2015, 4:56 PM

Change 240957 merged by jenkins-bot:
Interlanguage link: Avoid the requirement of jquery.uls.data module on page load

https://gerrit.wikimedia.org/r/240957

Diffusion mentioned this in rMEXTf7c2e50fdf8c: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Sep 29 2015, 4:56 PM
• santhosh mentioned this in rECTXafbcd62875e5: Interlanguage link: Avoid the requirement of jquery.uls.data module on page load.Sep 29 2015, 4:57 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 29 2015, 9:01 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 11:02 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:48 AM
He7d3r added a comment.Oct 1 2015, 9:39 PM

I saw this again today on ptwiki (1.27.0-wmf.1), at
https://pt.wikipedia.org/w/index.php?diff=43548682

The error came from
https://pt.wikipedia.org/w/load.php?debug=false&lang=pt&modules=ext.cx.interlanguagelink&skin=vector&version=2aa3f6b8caf2

Teles subscribed.Oct 3 2015, 2:14 AM
Alchimista subscribed.Oct 4 2015, 4:28 PM
gerritbot added a comment.Oct 4 2015, 11:34 PM

Change 243602 had a related patch set uploaded (by Ori.livneh):
ext.cx.interlanguagelink: declare dependency on jquery.uls.data

https://gerrit.wikimedia.org/r/243602

gerritbot added a comment.Oct 4 2015, 11:34 PM

Change 243602 merged by Ori.livneh:
ext.cx.interlanguagelink: declare dependency on jquery.uls.data

https://gerrit.wikimedia.org/r/243602

ori mentioned this in rMW8c80ec1273a4: Updated mediawiki/core Project: mediawiki/extensions/ContentTranslation….Oct 4 2015, 11:34 PM
ori mentioned this in rECTXdb4be17812e0: ext.cx.interlanguagelink: declare dependency on jquery.uls.data.
ori added a comment.Oct 4 2015, 11:36 PM

Should be fixed within the next five minutes.

gerritbot added a comment.Oct 5 2015, 5:23 AM

Change 243611 had a related patch set uploaded (by KartikMistry):
Interlanguage link: Avoid the requirement of jquery.uls.data module on page load

https://gerrit.wikimedia.org/r/243611

gerritbot added a comment.Oct 5 2015, 5:29 AM

Change 243611 abandoned by KartikMistry:
Interlanguage link: Avoid the requirement of jquery.uls.data module on page load

Reason:
Will go with the train.

https://gerrit.wikimedia.org/r/243611

FcoLeonSaudanha subscribed.Oct 5 2015, 2:40 PM

@ori the bug is resolved ;-). Greetings :-)!

• santhosh mentioned this in T118912: jquery.uls.data is loaded on every page despite rarely being used.Mar 30 2016, 6:12 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL