Page MenuHomePhabricator
Create Task
Maniphest T113677

Make OOjs UI in MediaWiki more lightweight, so that we can load it by default on every page without issue
Closed, ResolvedPublic
Actions

Description

Trying to use the JavaScript version of OOUI in MediaWiki is extremely heavy. This caused issues for Echo when it tried to use it (T112401) and will probably cause problems in the future. Even lazy-loading is problematic because the progress bars you'd use to indicate that something is being loaded...are also in the giant oojs-ui module.

From mw.loader.inspect() – post-ResourceLoder minification but pre-gzip:

ModuleBeforeas of wmf.13
oojs-ui(-core)225KB111.7 KiB
oojs-ui-toolbarsN/A35.0 KiB
oojs-ui-widgetsN/A90.6 KiB
oojs-ui-windowsN/A47.5 KiB
oojs-ui(-core).styles89.5KB49.3 KiB
oojs-ui.styles.icons129KB77.6 KiB
oojs-ui.styles.indicators24.8KB15.4 KiB
oojs-ui.styles.textures7.3KB4.1 KiB

This is a tracking bug for ways to make it more lightweight.

Details

SubjectRepoBranchLines +/-
resources: Load OOjs UI from its four partsmediawiki/coremaster+26 K -26 K
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Sep 24 2015, 10:32 PM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added projects: OOUI, MediaWiki-Interface, UI-Standardization, Performance Issue, Tracking-Neverending.
Legoktm added subscribers: Legoktm, matmarex.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2015, 10:32 PM
Legoktm added subtasks: T108733: MediaWiki Widgets module loads all modules instead of the only the desired one, T112347: Split OOjs UI's distribution .css files into code required by PHP version, and required by JS only.Sep 24 2015, 10:33 PM
Jdforrester-WMF triaged this task as Medium priority.Sep 25 2015, 9:51 AM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.
• Prtksxna added a parent task: T107953: Use progressive for selected states in OOUI toolbars.Nov 4 2015, 2:17 AM
Volker_E added a subscriber: Volker_E.Nov 4 2015, 2:39 AM
Jdforrester-WMF renamed this task from Make using OOjs UI in MediaWiki more lightweight (tracking) to Make using OOjs UI in MediaWiki more lightweight.Nov 4 2015, 2:08 PM
Jdforrester-WMF raised the priority of this task from Medium to High.
Jdforrester-WMF set Security to None.
Jdforrester-WMF removed a project: Tracking-Neverending.
Glaisher added a subscriber: Glaisher.Nov 9 2015, 5:55 AM
Isarra moved this task from Backlog to General requests on the MediaWiki-Interface board.Nov 10 2015, 10:05 PM
Volker_E removed a project: UI-Standardization.Nov 19 2015, 11:27 PM
demon closed subtask T108733: MediaWiki Widgets module loads all modules instead of the only the desired one as Resolved.Nov 24 2015, 5:57 PM
Jdlrobson added a parent task: T116624: Add watchstars to uniform cards.Dec 2 2015, 1:53 AM
Jdlrobson added a parent task: T95952: [Epic] Merge OOJS UI and MobileFrontend View code.
santhosh added a subscriber: santhosh.Dec 2 2015, 3:43 AM
Nikerabbit added a subscriber: Nikerabbit.Dec 2 2015, 12:21 PM
• RobLa-WMF added subscribers: Jdlrobson, Anomie, • RobLa-WMF.Dec 14 2015, 5:47 AM

Per discussion on wikitech-l, @Jdlrobson suggested last week (see Wikitech-l: Re: Who owns (or should own) OOjs UI?) that this general area might be a good Wikimedia-Developer-Summit-2016 topic. Is there any interest from anyone involved here? People I could envision being part of a conversation (among others): @Legoktm, @Jdforrester-WMF, @Volker_E, @Anomie, @Jdlrobson. This task and its blockers seems like something worth at least informal discussion.

matmarex added a subtask: T125292: Optimize how we load OOUI in MediaWiki.Jan 30 2016, 10:04 AM
Jdforrester-WMF closed subtask T113681: Split oojs-ui module into smaller ones as Resolved.Feb 1 2016, 9:34 PM
Jdforrester-WMF closed subtask T112347: Split OOjs UI's distribution .css files into code required by PHP version, and required by JS only as Resolved.Feb 1 2016, 9:54 PM
matmarex reopened subtask T113681: Split oojs-ui module into smaller ones as Open.Feb 1 2016, 11:43 PM
gerritbot added a subscriber: gerritbot.Feb 3 2016, 6:32 PM

Change 267799 had a related patch set uploaded (by Jforrester):
resources: Load OOjs UI from its four parts

https://gerrit.wikimedia.org/r/267799

gerritbot added a project: Patch-For-Review.Feb 3 2016, 6:32 PM
Jdforrester-WMF closed subtask T113681: Split oojs-ui module into smaller ones as Resolved.Feb 3 2016, 6:43 PM
gerritbot added a comment.Feb 3 2016, 9:38 PM

Change 267799 merged by jenkins-bot:
resources: Load OOjs UI from its four parts

https://gerrit.wikimedia.org/r/267799

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-02-09_(1.27.0-wmf.13)), MW-1.27-release-notes.Feb 3 2016, 10:00 PM
Jdforrester-WMF added a parent task: T125725: [epic] Update autocomplete search box with metadata and remove and delete the old searchSuggest system.Feb 3 2016, 10:30 PM
Jdforrester-WMF updated the task description. (Show Details)Feb 11 2016, 7:42 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF removed a subtask: T125292: Optimize how we load OOUI in MediaWiki.Feb 11 2016, 10:19 PM
Jdforrester-WMF mentioned this in T125292: Optimize how we load OOUI in MediaWiki.
Jdforrester-WMF updated the task description. (Show Details)Feb 12 2016, 9:23 PM
ori created subtask T127627: Add Grunt tasks for optimizing PNGs for non-MediaWiki users.Feb 21 2016, 4:59 AM
Jdforrester-WMF removed a subtask: T127627: Add Grunt tasks for optimizing PNGs for non-MediaWiki users.Feb 24 2016, 4:18 PM
Jdforrester-WMF mentioned this in T127627: Add Grunt tasks for optimizing PNGs for non-MediaWiki users.
Legoktm created subtask T128891: Use OO.ui.alert() instead of plain alert for Thanks error messages.Mar 4 2016, 6:55 PM
Legoktm removed a subtask: T128891: Use OO.ui.alert() instead of plain alert for Thanks error messages.Mar 4 2016, 11:09 PM
Legoktm added a parent task: T128891: Use OO.ui.alert() instead of plain alert for Thanks error messages.
Peter closed subtask T127125: Create a static version of [[en:Barack Obama]] in mw-config/speedtests with OOjs UI core loaded as Resolved.Mar 31 2016, 7:24 PM
Jdlrobson added a subtask: T131095: MobileFrontend editor and notifications sometimes take more than 5 seconds to load and cause browser tests to fail.Apr 1 2016, 7:12 AM
Jdforrester-WMF renamed this task from Make using OOjs UI in MediaWiki more lightweight to Make using OOjs UI in MediaWiki more lightweight, then load it by default on every page.Apr 2 2016, 3:48 PM
Jdforrester-WMF removed a subtask: T131095: MobileFrontend editor and notifications sometimes take more than 5 seconds to load and cause browser tests to fail.
Jdforrester-WMF claimed this task.Jun 10 2016, 12:12 PM
Jdforrester-WMF removed projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-02-09_(1.27.0-wmf.13)).
Krinkle renamed this task from Make using OOjs UI in MediaWiki more lightweight, then load it by default on every page to Make OOjs UI in MediaWiki more lightweight.Jun 10 2016, 12:26 PM
Jdforrester-WMF added a subscriber: Krinkle.Jun 10 2016, 12:29 PM

@Krinkle: Why did you revert the change to the scope of this, agreed back in January at the developer summit?

Krinkle added a comment.Jun 10 2016, 12:44 PM

Loading OOjs UI on every page isn't a goal in itself. (Aside from legacy components, we never load stuff unconditionally in MediaWiki). We want to be able to use it on any page (which isn't semantically the same as loading it on all pages).

In order to allow usage on any page, it needs to be more lightweight. This task tracks getting OOjs UI in MediaWiki lightweight enough.

There isn't going to be a commit that will literally just load oojs-ui on all pages.

Once this task is resolved, we can allow any part of core, skins or extensions to add OOjs UI components to a page without worrying about the added size of loading oojs-ui.

It's also okay if Echo and/or Vector will unconditionally have an OOjs UI component on all pages.

I'm merely saying that from a code stability and maintainability perspective want to keep a link between loading OOjs UI and there being one or more OOjs UI elements in the output. Which means if someone has a custom skin on their wiki, or if doesn't have certain extensions installed or whatever in theory, it wouldn't load OOjs UI. This is merely in principle. In practice, yes, from an end-user perspective of most wikis, it'll be loaded everywhere.

Jdforrester-WMF added a comment.Jun 10 2016, 2:04 PM
In T113677#2371436, @Krinkle wrote:

In order to allow usage on any page, it needs to be more lightweight. This task tracks getting OOjs UI in MediaWiki lightweight enough.

No it doesn't. That task was complete as judged by Performance in February.

Jdforrester-WMF renamed this task from Make OOjs UI in MediaWiki more lightweight to Make OOjs UI in MediaWiki more lightweight, so that we can load it by default on every page without issue.Jun 10 2016, 2:05 PM
Krinkle added a comment.Jun 10 2016, 2:09 PM
In T113677#2371707, @Jdforrester-WMF wrote:
In T113677#2371436, @Krinkle wrote:

This task tracks getting OOjs UI in MediaWiki lightweight enough.

No it doesn't. That task was complete as judged by Performance in February [2016].

Yes, that was after this task was created -

@Legoktm created task with description [September 2015]:

This is a tracking bug for ways to make it more lightweight.

What's keeping this task open still?

Jdforrester-WMF closed this task as Resolved.Jul 20 2016, 7:09 PM
In T113677#2371729, @Krinkle wrote:
@Legoktm created task with description [September 2015]:

This is a tracking bug for ways to make it more lightweight.

What's keeping this task open still?

Agreed.

Aklapper removed subscribers: • RobLa-WMF, Anomie.Oct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL