Page MenuHomePhabricator

wpReason ignored when performing page moves
Closed, ResolvedPublic

Description

In a recent MediaWiki update the move interface was slightly changed (see T86865: Convert Special:MovePage to OOUI-based form). However, when performing a move with a "wpReason" parameter in the URL, the contents of that parameter are no longer prefilled into the "reason" field. According to PrimeHunter it still works for deletion, though.

The same issue also affects re-submitting the form after errors (or to confirm moving over an existing page) – the contents of the "reason" field disappear and have to be re-typed.

See https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#File_renaming for a constructed example.

Event Timeline

BethNaught raised the priority of this task from to Needs Triage.
BethNaught updated the task description. (Show Details)
BethNaught added a subscriber: BethNaught.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2015, 11:03 AM
Glaisher triaged this task as High priority.Sep 25 2015, 11:42 AM
Glaisher added a subscriber: Glaisher.

Change 241015 had a related patch set uploaded (by Glaisher):
MovePageForm: Add value attribute to reason field back again

https://gerrit.wikimedia.org/r/241015

I don't think we could get this deployed to Wikipedia before Monday (no SWAT until then) unless a deployer helps.

Glaisher updated the task description. (Show Details)Sep 25 2015, 11:51 AM
Glaisher set Security to None.

I don't think we could get this deployed to Wikipedia before Monday (no SWAT until then) unless a deployer helps.

Is this important enough to justify deploying it early?

I don't think we could get this deployed to Wikipedia before Monday (no SWAT until then) unless a deployer helps.

Is this important enough to justify deploying it early?

I personally don't think so. But looking at the amount of reports at the other task, it might be very needed for Wikipedia contributors.

Change 241015 merged by jenkins-bot:
MovePageForm: Add value attribute to reason field back again

https://gerrit.wikimedia.org/r/241015

Sorry, I goofed up, and I only just came online today.

To clarify, this affects pre-filling the reason field via URL parameters (which is ignored), and re-submitting the form after an error occurs (the reason disappears and has to be re-typed). It does not affect normal form submission (the reason you provide is correctly saved).

I'm not a deployer myself, so I'm at your mercy. I think it's an obvious enough patch that it could be done even on a Friday, but I'll understand if it has to be pushed to Monday's SWAT.

matmarex updated the task description. (Show Details)Sep 25 2015, 1:07 PM

Maybe @greg can help to decide? :)

Change 241045 had a related patch set uploaded (by Alex Monk):
MovePageForm: Add value attribute to reason field back again

https://gerrit.wikimedia.org/r/241045

Change 241045 merged by jenkins-bot:
MovePageForm: Add value attribute to reason field back again

https://gerrit.wikimedia.org/r/241045

Change deployed by @Krenair, all should be in order again.

matmarex closed this task as Resolved.Sep 25 2015, 2:39 PM
matmarex removed a project: Patch-For-Review.