Page MenuHomePhabricator

Deprecated : Methods with the same name as their class when used with PHP 7
Closed, ResolvedPublic

Description

When testing against PHP 7 you get: Deprecated : Methods with the same name as their class

This is the case in:

  • DT_ImportXML.php
  • DT_ViewXML.php

I hope I did this right. Patch below.

Event Timeline

Jongfeli raised the priority of this task from to Needs Triage.
Jongfeli updated the task description. (Show Details)
Jongfeli added a subscriber: Jongfeli.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2015, 12:58 PM
Jongfeli set Security to None.Sep 25 2015, 1:08 PM
Jongfeli added a subscriber: Yaron_Koren.

Thanks for taking a look at the code!

You are very welcome to use developer access to submit this as a Git branch directly into Gerrit.
If you don't want to set up Git/Gerrit, you can also use the Gerrit Patch Uploader. Thanks again!

Reedy added a subscriber: Reedy.Sep 25 2015, 1:34 PM

Yay, PHP4 stuff that should've been removed a long time ago

It has been fixed with this commit. Thanks Yaron.

Jongfeli closed this task as Resolved.Oct 23 2015, 7:24 AM