Page MenuHomePhabricator
Create Task
Maniphest T113740

DateInputWidget: Rounded corders are internally and externally inconsistent
Closed, ResolvedPublic
Actions

Description

They are inconsistent within the widget:

and are generally inconsistent with the theme that avoids them.

On the 'month select' page there are large rounded corners, whereas similar situations (dropdownWidget) have square corners.

I recommend getting rid completely.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+1 -29Remove border radii from CalendarWidget
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Sep 25 2015, 2:53 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: OOUI.
Esanders added subscribers: Esanders, Aklapper.
Esanders renamed this task from DateInputWidget: Rounded corders are internall and externally inconsistent to DateInputWidget: Rounded corders are internally and externally inconsistent.Sep 25 2015, 5:12 PM
Esanders set Security to None.
gerritbot added a subscriber: gerritbot.Sep 25 2015, 5:35 PM

Change 241092 had a related patch set uploaded (by Esanders):
Remove border radii from CalendarWidget

https://gerrit.wikimedia.org/r/241092

gerritbot added a project: Patch-For-Review.Sep 25 2015, 5:35 PM
Jdforrester-WMF assigned this task to Esanders.Sep 26 2015, 11:46 AM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added UI-Standardization; removed OOUI.
matmarex closed this task as Resolved.Sep 28 2015, 5:39 PM
matmarex edited projects, added MediaWiki-Interface; removed Patch-For-Review.
gerritbot added a comment.Sep 28 2015, 5:48 PM

Change 241092 merged by jenkins-bot:
Remove border radii from CalendarWidget

https://gerrit.wikimedia.org/r/241092

matmarex mentioned this in rMW43374cbe1a96: Remove border radii from CalendarWidget.Sep 28 2015, 5:48 PM
ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)), MW-1.27-release-notes.Sep 29 2015, 10:13 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:48 AM
matmarex edited projects, added MW-1.26-release; removed MW-1.27-release-notes.Oct 16 2015, 6:43 PM
matmarex added a subscriber: matmarex.

Patches cherry-picked to REL1_26 in 03e6ac38bf51456d9035b58040422358c41939f7.

matmarex mentioned this in T149270: mw.widgets.DateInputWidget does not match the design of other widgets in MediaWiki theme.Nov 7 2016, 7:18 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL