Maniphest T113752

Convert PageApi to PageGateway pattern
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Sep 25 2015, 4:33 PM

Tags

Referenced Files

None

Subscribers

Description

We are converting our API classes to be gateways that don't extend the Api but rather interact with the API via an instance of mw.Api.
(Preliminary reading: http://martinfowler.com/eaaCatalog/gateway.html)
This class should be converted to a gateway

Details

	Subject	Repo	Branch	Lines +/-
	Hygiene: Convert PageApi to PageGateway	mediawiki/extensions/MobileFrontend	master	+153 -116

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T110102 Completely remove api.js and ForeignApi.js, their functionality has been upstreamed
		Resolved		Jdlrobson	T113752 Convert PageApi to PageGateway pattern

Event Timeline

Jdlrobson created this task.Sep 25 2015, 4:33 PM

Jdlrobson raised the priority of this task from to Low.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: MobileFrontend.

Jdlrobson moved this task to Backlog on the MobileFrontend board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2015, 4:33 PM

Change 240143 had a related patch set uploaded (by Jdlrobson):
Hygiene: Convert PageApi to PageGateway

https://gerrit.wikimedia.org/r/240143

gerritbot added a project: Patch-For-Review.Sep 25 2015, 4:34 PM

Jdlrobson mentioned this in T110718: Use core API code - reduce size of JS assets sent to mobile users.Sep 25 2015, 6:05 PM

Jdlrobson added a parent task: T110102: Completely remove api.js and ForeignApi.js, their functionality has been upstreamed.Sep 26 2015, 12:45 AM

Jdlrobson added a project: reading-web-sprint-58-The-Sixth-Sense.Oct 9 2015, 8:44 PM

Jdlrobson set Security to None.

Jdlrobson claimed this task.Oct 13 2015, 10:05 PM

Jdlrobson moved this task from Needs Analysis to Code Review on the reading-web-sprint-58-The-Sixth-Sense board.Oct 15 2015, 5:17 PM

phuedx updated the task description. (Show Details)Oct 16 2015, 8:37 AM

phuedx moved this task from Code Review to -1 (Needs More Work) on the reading-web-sprint-58-The-Sixth-Sense board.Oct 16 2015, 10:32 AM

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the reading-web-sprint-58-The-Sixth-Sense board.Oct 16 2015, 5:00 PM

• jhobs moved this task from Code Review to -1 (Needs More Work) on the reading-web-sprint-58-The-Sixth-Sense board.Oct 26 2015, 2:29 PM

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the reading-web-sprint-58-The-Sixth-Sense board.Oct 26 2015, 4:10 PM

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the reading-web-sprint-58-The-Sixth-Sense board.Oct 26 2015, 4:20 PM

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the reading-web-sprint-58-The-Sixth-Sense board.Oct 26 2015, 4:44 PM

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the reading-web-sprint-58-The-Sixth-Sense board.Oct 26 2015, 5:00 PM

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the reading-web-sprint-58-The-Sixth-Sense board.Oct 26 2015, 5:22 PM

Jdlrobson removed a project: reading-web-sprint-58-The-Sixth-Sense.Oct 28 2015, 9:25 PM

Jdlrobson moved this task from Backlog to Team:Growth on the MobileFrontend board.Nov 4 2015, 5:03 PM

Jdlrobson added a project: Reading Web Sprint 60 - Boom Headshot!.Nov 6 2015, 10:54 PM

Jdlrobson moved this task from Needs Analysis to Code Review on the Reading Web Sprint 60 - Boom Headshot! board.

@jhobs: I've reviewed 240143 and tested it locally but since you said that you were going to review it at yesterday's standup I've only +1d it.

Change 240143 merged by jenkins-bot:
Hygiene: Convert PageApi to PageGateway

https://gerrit.wikimedia.org/r/240143

phuedx moved this task from Code Review to Ready for Signoff on the Reading Web Sprint 60 - Boom Headshot! board.Nov 10 2015, 9:10 PM

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-17_(1.27.0-wmf.7)).Nov 10 2015, 10:00 PM

Signing off, the task is purely technical.

• bmansurov moved this task from Ready for Signoff to Done on the Reading Web Sprint 60 - Boom Headshot! board.Nov 19 2015, 2:15 AM

Tested the talk overlay and and wikitext editor on the Beta Cluster and they both LGTM.