We were badly bitten earlier by a mismatch between 'true' and true. Jenkins should scan all .pp files and reject anything with
'true'
'false
'True'
'False'
'TRUE'
etc.
I have the feeling we discussed and rejected this in the past, but I'm mad about it again.
Seems like we want to enable the relevant puppet-lint check http://puppet-lint.com/checks/quoted_booleans/
Unfortunately some of our classes expect quoted boolean and there is a bunch of crazy equality check such as: if $foo == 'true' which would not match when $foo = True.
The test is disabled in operations/puppet.git via the file /.puppet-lint.rc:
# "true" and "false" are everywhere. --no-quoted_booleans-check
So one can send a change for review without the line and look at the puppet-lint jobs.
Change 241111 had a related patch set uploaded (by Hashar):
puppet-lint: enable quoted_booleans-check
Change 241235 had a related patch set uploaded (by Andrew Bogott):
Rsync: Unquote booleans
Change 241236 had a related patch set uploaded (by Andrew Bogott):
Logstash: Fixed a quoted boolean in a code comment.
Change 241237 had a related patch set uploaded (by Andrew Bogott):
interface: dequote booleans
Change 241238 had a related patch set uploaded (by Andrew Bogott):
Cassandra: dequote some booleans.
Change 241239 had a related patch set uploaded (by Andrew Bogott):
Grafana: dequote booleans.
Change 241240 had a related patch set uploaded (by Andrew Bogott):
Gerrit role: dequote booleans
Change 241241 had a related patch set uploaded (by Andrew Bogott):
Mark salt grain bool values with # lint:ignore:quoted_booleans
Change 241242 had a related patch set uploaded (by Andrew Bogott):
webserver::php5 unquote a boolean.
Change 241243 had a related patch set uploaded (by Andrew Bogott):
Webserver ca: disable the quoted-bool lint check
Change 241244 had a related patch set uploaded (by Andrew Bogott):
Diamond: Turn off lint check for quoted bools.
Change 241245 had a related patch set uploaded (by Andrew Bogott):
Disable quoted_boolean lint check around is_virtual refs.
Change 241246 had a related patch set uploaded (by Andrew Bogott):
Root out a long chain of quoted bools in nagios/icinga/nrpe
A gotcha is the puppet-lint check for boolean is only a warning. In Jenkins we have two jobs:
puppetlint-lenient : solely process errors and votes -1 on failure
puppetlint-strict : does warning as well but is not voting
So even if we fix the boolean quotes, the errors will only be in the -strict job and would not cause a -1 vote for now.
Luckily there are only a few warnings left. If we solved them we can remove the -lenient job and make the -strict one voting. This way warnings will cause a -1 as well :-)
Change 241246 merged by Andrew Bogott:
Root out a long chain of quoted bools in nagios/icinga/nrpe
Change 241236 merged by Andrew Bogott:
Logstash: Fixed a quoted boolean in a code comment.
Change 242170 had a related patch set uploaded (by Andrew Bogott):
Dequote one more nrpe critical setting
Change 242171 had a related patch set uploaded (by Andrew Bogott):
dataset: Remove needless quotes around a 'true'
Change 241241 merged by Andrew Bogott:
Mark salt grain bool values with # lint:ignore:quoted_booleans
Change 241243 merged by Andrew Bogott:
Webserver ca: disable the quoted-bool lint check
Change 241244 merged by Andrew Bogott:
Diamond: Turn off lint check for quoted bools.
Change 241245 merged by Andrew Bogott:
Disable quoted_boolean lint check around is_virtual refs.
Change 242171 merged by Andrew Bogott:
dataset: Remove needless quotes around a 'true'
Change 243176 had a related patch set uploaded (by Andrew Bogott):
Varnish: Add lint:ignore:quoted_booleans around a boolean that needs quoting.
Change 243176 merged by Andrew Bogott:
Varnish: Add lint:ignore:quoted_booleans around a boolean that needs quoting.
Change 522992 had a related patch set uploaded (by CDanis; owner: CDanis):
[operations/puppet@production] nrpe: $critical is a boolean, NOT a string! 😤
Change 522992 merged by CDanis:
[operations/puppet@production] nrpe: $critical is a boolean, NOT a string! 😤