Page MenuHomePhabricator

Incorrect field type in database patch
Closed, ResolvedPublic


Author: thomas.dalton

The database patch "patch-rc_deleted.sql" has an incorrect data type which
causes update.php to fail. I have a patch to fix it, but no commit access, so
I'll just upload it here.

Version: unspecified
Severity: critical
OS: Windows XP
Platform: PC



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:38 PM
bzimport set Reference to bz9383.
bzimport added a subscriber: Unknown Object (MLST).

thomas.dalton wrote:

Fix incorrect data type in patch-rc_deleted


robchur wrote:

"BLOB" is a valid column data type, although it can't have a default value in
MySQL strict mode.

thomas.dalton wrote:

Does it need to be a BLOB? If so, we can just remove the default.

rc_params is defined exactly the same as log_params. Odd.

robchur wrote:

(In reply to comment #4)

rc_params is defined exactly the same as log_params. Odd.

MySQL won't accept a default value for a BLOB column when operating in strict
mode; patches aren't split up to cope with the three schema variants we offer.