Page MenuHomePhabricator
Create Task
Maniphest T113839

Stylesheets should not both specify "media" and contain @media
Closed, ResolvedPublic
Actions

Description

I uploaded a patch set for the Disambiguator extension, and there was an unrelated test failure, apparently caused by the Metrolook skin. This should be fixed.

06:46:12 1) ResourcesTest::testStyleMedia with data set #21 ('skins.metrolook.styles.responsive', 'screen', 'screen.mobile.less', stdClass)
06:46:12 Stylesheets should not both specify "media" and contain @media
06:46:12 Failed asserting that false is true.
06:46:12 
06:46:12 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/structure/ResourcesTest.php:36
06:46:12 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:137

Related Objects
Search...

Event Timeline

PleaseStand created this task.Sep 26 2015, 8:43 AM
PleaseStand raised the priority of this task from to Needs Triage.
PleaseStand updated the task description. (Show Details)
PleaseStand added a project: Metrolook.
PleaseStand subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2015, 8:43 AM
Paladox set Security to None.Sep 26 2015, 11:25 AM
Paladox subscribed.
Paladox added a comment.Sep 26 2015, 11:35 AM

I think this is to do with https://git.wikimedia.org/blob/mediawiki%2Fskins%2FMetrolook/b9185c73b7a6d64f0f00067e078a6b5c4bca1af0/skin.json#L61 and https://git.wikimedia.org/blob/mediawiki%2Fskins%2FMetrolook/b9185c73b7a6d64f0f00067e078a6b5c4bca1af0/components%2Fmobile.less#L5

Paladox added a comment.Sep 26 2015, 11:40 AM

And could be to do with extension-unittests-generic test added recently to metrolook.

Paladox added a comment.Sep 26 2015, 11:40 AM

Not sure how to fix this problem.

hashar mentioned this in T113841: mwext-testextension-* jobs does not remove skins from previous runs.Sep 26 2015, 11:44 AM
hashar added a subtask: T113841: mwext-testextension-* jobs does not remove skins from previous runs.
hashar subscribed.

The root cause is T113841 , the skins are not deleted between runs.

hashar closed subtask T113841: mwext-testextension-* jobs does not remove skins from previous runs as Resolved.Dec 15 2016, 7:48 AM

Will be fixed when the Jenkins jobs mw-testextension* are moved to Nodepool instance. There will be no more any leftover from previous build.

Paladox added a comment.EditedDec 15 2016, 8:59 AM

@hashar but this fails on the skins tests for example the Metrolook one. Probably want to skip this one on the skins test please.

hashar mentioned this in T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.EditedApr 30 2018, 3:14 PM
This comment has been deleted.
hashar closed this task as Resolved.Apr 30 2018, 3:17 PM
hashar claimed this task.

The original issue got fixed when migrating jobs to Nodepool which starts with an empty workspace. Hence there is no more an unrelated skin/extension left behind from a previous build.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL