Page MenuHomePhabricator
Create Task
Maniphest T113846

Fix problems reported by RuboCop in GettingStarted
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Fixed Style/Tab RuboCop offensemediawiki/extensions/GettingStartedmaster+38 -64
Fixed Style/StringLiterals RuboCop offensemediawiki/extensions/GettingStartedmaster+16 -23
Fixed Style/SpaceInsideStringInterpolation RuboCop offensemediawiki/extensions/GettingStartedmaster+1 -8
Fixed Style/IndentationWidth RuboCop offensemediawiki/extensions/GettingStartedmaster+10 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Sep 26 2015, 2:49 PM
zeljkofilipin claimed this task.
zeljkofilipin raised the priority of this task from to Medium.
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin added a project: Browser-Tests-Infrastructure.
zeljkofilipin subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2015, 2:49 PM
zeljkofilipin mentioned this in T91485: Fix easy problems reported by RuboCop.Sep 26 2015, 2:50 PM
gerritbot subscribed.Sep 26 2015, 3:39 PM

Change 241320 had a related patch set uploaded (by Zfilipin):
Fixed Style/IndentationWidth RuboCop offense

https://gerrit.wikimedia.org/r/241320

gerritbot added a project: Patch-For-Review.Sep 26 2015, 3:39 PM

Change 241321 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceInsideStringInterpolation RuboCop offense

https://gerrit.wikimedia.org/r/241321

gerritbot added a comment.Sep 26 2015, 3:39 PM

Change 241322 had a related patch set uploaded (by Zfilipin):
Fixed Style/StringLiterals RuboCop offense

https://gerrit.wikimedia.org/r/241322

gerritbot added a comment.Sep 26 2015, 3:39 PM

Change 241323 had a related patch set uploaded (by Zfilipin):
Fixed Style/Tab RuboCop offense

https://gerrit.wikimedia.org/r/241323

zeljkofilipin moved this task from Inbox to Waiting on the Browser-Tests-Infrastructure board.Sep 26 2015, 3:39 PM
gerritbot added a comment.Sep 28 2015, 4:03 PM

Change 241320 abandoned by Zfilipin:
Fixed Style/IndentationWidth RuboCop offense

Reason:
Not needed. https://gerrit.wikimedia.org/r/#/c/241323/ fixes this problem.

https://gerrit.wikimedia.org/r/241320

gerritbot added a comment.Sep 29 2015, 10:28 AM

Change 241321 merged by jenkins-bot:
Fixed Style/SpaceInsideStringInterpolation RuboCop offense

https://gerrit.wikimedia.org/r/241321

gerritbot added a comment.Sep 29 2015, 10:28 AM

Change 241322 merged by jenkins-bot:
Fixed Style/StringLiterals RuboCop offense

https://gerrit.wikimedia.org/r/241322

gerritbot added a comment.Sep 29 2015, 10:28 AM

Change 241323 merged by jenkins-bot:
Fixed Style/Tab RuboCop offense

https://gerrit.wikimedia.org/r/241323

zeljkofilipin mentioned this in rMEXT80296ec70b84: Updated mediawiki/extensions Project: mediawiki/extensions/GettingStarted….Sep 29 2015, 10:29 AM
zeljkofilipin mentioned this in rMEXTe520f80df83d: Updated mediawiki/extensions Project: mediawiki/extensions/GettingStarted….
zeljkofilipin mentioned this in rMEXT7f62ca4e3a81: Updated mediawiki/extensions Project: mediawiki/extensions/GettingStarted….
zeljkofilipin mentioned this in rEGSTa69f7bd9244c: Fixed Style/SpaceInsideStringInterpolation RuboCop offense.
zeljkofilipin mentioned this in rEGSTbb6de601bf85: Fixed Style/StringLiterals RuboCop offense.
zeljkofilipin mentioned this in rEGST95ede3055a36: Fixed Style/Tab RuboCop offense.
zeljkofilipin closed this task as Resolved.Sep 29 2015, 10:30 AM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 10:16 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL