Page MenuHomePhabricator

@codingStandardsIgnoreStart doesn't seem to help avoid phpcs errors inside comments
Closed, DuplicatePublic

Description

See https://gerrit.wikimedia.org/r/#/c/241327/1/includes/media/XMP.php line 1284: this fails in phpcs even though it's inside @codingStandardsIgnoreStart / @codingStandardsIgnoreEnd

Event Timeline

Amire80 raised the priority of this task from to Low.
Amire80 updated the task description. (Show Details)
Amire80 updated the task description. (Show Details)
Amire80 set Security to None.
Amire80 added subscribers: Amire80, gerritbot, Aklapper and 4 others.

I guess an upstream issue needs to be filed about this?

Maybe, I'm not really a phpcs expert.

Change 242450 had a related patch set uploaded (by Amire80):
Use correct comment format for codingStandardsIgnoreStart

https://gerrit.wikimedia.org/r/242450

Change 242450 merged by jenkins-bot:
Use correct comment format for codingStandardsIgnoreStart

https://gerrit.wikimedia.org/r/242450