Page MenuHomePhabricator

@codingStandardsIgnoreStart doesn't seem to help avoid phpcs errors inside comments
Closed, DuplicatePublic

Description

See https://gerrit.wikimedia.org/r/#/c/241327/1/includes/media/XMP.php line 1284: this fails in phpcs even though it's inside @codingStandardsIgnoreStart / @codingStandardsIgnoreEnd

Details

Related Gerrit Patches:

Event Timeline

Amire80 created this task.Sep 26 2015, 4:23 PM
Amire80 raised the priority of this task from to Low.
Amire80 updated the task description. (Show Details)
Amire80 updated the task description. (Show Details)
Amire80 set Security to None.
Amire80 added subscribers: Amire80, gerritbot, Aklapper and 4 others.
Reedy moved this task from Untriaged to CI on the MediaWiki-Codesniffer board.Sep 26 2015, 8:48 PM
Reedy moved this task from CI to Upstream on the MediaWiki-Codesniffer board.
Reedy added a comment.Sep 26 2015, 8:53 PM

I guess an upstream issue needs to be filed about this?

Maybe, I'm not really a phpcs expert.

Change 242450 had a related patch set uploaded (by Amire80):
Use correct comment format for codingStandardsIgnoreStart

https://gerrit.wikimedia.org/r/242450

Legoktm closed this task as Invalid.Oct 1 2015, 2:30 AM
Legoktm claimed this task.

Change 242450 merged by jenkins-bot:
Use correct comment format for codingStandardsIgnoreStart

https://gerrit.wikimedia.org/r/242450