Page MenuHomePhabricator

Figure out why PHPCS is unable to parse FormatMetadata.php
Closed, ResolvedPublic

Description

In rMWdf706d2457e6: Add // @codingStandardsIgnoreFile to FormatMetadata I disabled parsing of the file entirely because it caused phcps to throw errors. This is not ideal and we should figure out if we can work around this in PHPCS or whether the file needs refactoring...or something.

Event Timeline

Legoktm created this task.Sep 27 2015, 7:30 AM
Legoktm raised the priority of this task from to Low.
Legoktm updated the task description. (Show Details)
Legoktm added a subscriber: Legoktm.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2015, 7:30 AM

Legoktm, Could you elaborate on how to reproduce this ?

I took the latest includes/media/FormatMetadata.php from core and I don't get any issues with parsing right now.

I'm using the following args phpcs --standard=./MediaWiki ../core/includes/media/FormatMetadata.php

TasneemLo added a comment.EditedOct 7 2015, 4:06 PM

I'm setting the task status to resolved as the problem seems to have fixed itself \^_^/

(Please revert it back if this is the wrong conclusion)

TasneemLo closed this task as Resolved.Oct 7 2015, 4:06 PM
TasneemLo set Security to None.