It seems that our HHVM was built without support for compress.bzip2 streams:
<?php
print_r(stream_get_wrappers());
?>
Array
(
[0] => compress.zlib [1] => data [2] => file [3] => glob [4] => http [5] => https [6] => phar [7] => php [8] => zip
)
missing is compress.bzip2, needed for dumps to run on HHVM.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Backport of D2486378: Implement compress.bzip2:// stream wrapper | operations/debs/hhvm | master | +167 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Legoktm | T75901 Drop PHP 5.3 support | |||
| Declined | • demon | T91590 [Spike] Try out hack (<?hh) for mediawiki-config | |||
| Resolved | Joe | T104147 can we get rid of rsvg security patch? | |||
| Resolved | Reedy | T94149 Get rid of Zend 5.5 tests for wmf branches | |||
| Resolved | None | T86081 Complete the use of HHVM over Zend PHP on the Wikimedia cluster | |||
| Declined | hashar | T64519 Upgrade git > 1.7 | |||
| Resolved | • brooke | T69951 Vagrant+TMH: webm transcodes don't play in Firefox (upstream Ubuntu/avconv issue) | |||
| Resolved | None | T34317 PDF export extension fails to render Arabic characters in monospace font | |||
| Declined | None | T65899 Upgrade Wikimedia servers to Ubuntu Trusty (14.04) | |||
| Declined | ArielGlenn | T94277 Convert snapshot hosts to use HHVM and trusty | |||
| Resolved | ori | T113932 HHVM does not recognize compress.bzip2 streams |
This is true with FB's official package as well:
joe@gizmo:~$ hhvm --version
HipHop VM 3.9.1 (rel)
Compiler: tags/HHVM-3.9.1-0-g0f72cfc2f0a01fdfeb72fbcfeb247b72998a66db
Repo schema: 6416960c150a4a4726fda74b659105ded8819d9c
joe@gizmo:~$ hhvm test.php
Array
(
[0] => compress.zlib
[1] => data
[2] => file
[3] => glob
[4] => http
[5] => https
[6] => phar
[7] => php
[8] => zip
)#6314 has been fixed with https://github.com/facebook/hhvm/commit/46d04cfdb6b5987946f19ed6c65cee676e27b254.
@Joe, is this something that could/should be backported for us? Or would you rather we wait and pick up the release that has this fix in it?
Change 242773 had a related patch set uploaded (by BryanDavis):
Backport of D2486378: Implement compress.bzip2:// stream wrapper
Change 242773 merged by Ori.livneh:
Backport of D2486378: Implement compress.bzip2:// stream wrapper
home/ori/build-new/hhvm-3.6.5+dfsg1/hphp/runtime/ext/bz2/ext_bz2.cpp:40:11: error: ‘req’ does not name a type
virtual req::ptr<File> open(const String& filename,
^
/home/ori/build-new/hhvm-3.6.5+dfsg1/hphp/runtime/ext/bz2/ext_bz2.cpp:70:3: error: cannot declare variable ‘HPHP::{anony
mous}::s_bzip2_stream_wrapper’ to be of abstract type ‘HPHP::{anonymous}::BZ2StreamWrapper’
} s_bzip2_stream_wrapper;
^
/home/ori/build-new/hhvm-3.6.5+dfsg1/hphp/runtime/ext/bz2/ext_bz2.cpp:39:15: note: because the following virtual funct
ions are pure within ‘HPHP::{anonymous}::BZ2StreamWrapper’:
static struct BZ2StreamWrapper : Stream::Wrapper {
^
In file included from /home/ori/build-new/hhvm-3.6.5+dfsg1/hphp/runtime/ext/bz2/ext_bz2.cpp:20:0:
/home/ori/build-new/hhvm-3.6.5+dfsg1/hphp/runtime/base/stream-wrapper.h:40:26: note: virtual HPHP::SmartPtr<HPHP::Fil
e> HPHP::Stream::Wrapper::open(const HPHP::String&, const HPHP::String&, int, const HPHP::SmartPtr<HPHP::StreamContext>&
)
virtual SmartPtr<File> open(const String& filename,
^
/usr/bin/cmake -E cmake_progress_report /home/ori/build-new/hhvm-3.6.5+dfsg1/CMakeFilesori, you said in irc that the new package would be available on the snapshots last night, but I don't see it, or at least, if the new package is 3.6.5+dfsg1-1+wm7 it shows the same behavior as reported initially, i.e. no compress.bzip2. Am I doing something wrong? This is on snapshot1004.
Yeah, I hit another snag. I'm working on it at the moment, will have an update shortly.
I am stuck on this error:
/home/ori/build-old/hhvm-3.6.5+dfsg1/hphp/runtime/vm/jit/type.cpp: In member function ‘std::string HPHP::jit::Type::toString() const’:
/home/ori/build-old/hhvm-3.6.5+dfsg1/hphp/runtime/vm/jit/type.cpp:253:13: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retryin
g without
std::string Type::toString() const {
^So the word is that the backport of the patch is essentially not doable and so this must wait on the new version of HHVM, 3.9, being packaged for WMF.
Rumour has it that there are 3.11 packages someplace, but a quick check shows they are not yet in the repo, so must still be undergoing testing.
@ArielGlenn, 3.12.1 is now deployed everywhere, and:
[mw1099:~] $ hhvm --php -r 'var_dump( in_array( "compress.bzip2", stream_get_wrappers() ) );' bool(true)