Page MenuHomePhabricator
Create Task
Maniphest T113936

[Story] initial default display of article placeholder
Closed, ResolvedPublic
Actions

Description

Implement the very first version of the Article Placeholder's Lua libaries.

Details

SubjectRepoBranchLines +/-
Don't show titles if there is no contentmediawiki/extensions/ArticlePlaceholdermaster+10 -3
Add getter and setter for the default Lua libary.mediawiki/extensions/ArticlePlaceholdermaster+243 -104
Implement the Lua library for the default displaymediawiki/extensions/ArticlePlaceholdermaster+214 -37
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucie created this task.Sep 28 2015, 10:26 AM
Lucie claimed this task.
Lucie raised the priority of this task from to Medium.
Lucie updated the task description. (Show Details)
Lucie added projects: Story, Patch-For-Review, Wikidata, MediaWiki-extensions-WikibaseClient, ArticlePlaceholder, Wikidata-Sprint-2015-09-29.
Lucie added subscribers: hoo, Lucie.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2015, 10:26 AM
gerritbot subscribed.Sep 28 2015, 10:26 AM

Change 239128 had a related patch set uploaded (by Lucie Kaffee):
Implement the Lua library for the default display

https://gerrit.wikimedia.org/r/239128

Lucie moved this task from Incoming to To Do Next on the ArticlePlaceholder board.Sep 28 2015, 1:31 PM
Lucie moved this task from To Do Next to Doing on the ArticlePlaceholder board.Sep 28 2015, 1:39 PM
gerritbot added a comment.Sep 28 2015, 2:39 PM

Change 239128 merged by jenkins-bot:
Implement the Lua library for the default display

https://gerrit.wikimedia.org/r/239128

Diffusion mentioned this in rMEXT9d3f3f262051: Updated mediawiki/extensions Project: mediawiki/extensions/ArticlePlaceholder….Sep 28 2015, 2:39 PM
Diffusion mentioned this in rEARP733d598e50ef: Implement the Lua library for the default display.Sep 28 2015, 3:02 PM
Ricordisamoa renamed this task from initial default display of article playeholder to initial default display of article placeholder.Sep 28 2015, 6:41 PM
Ricordisamoa set Security to None.
Ricordisamoa edited subscribers, added: Ricordisamoa; removed: gerritbot.
Tobi_WMDE_SW moved this task from Proposed to Doing on the Wikidata-Sprint-2015-09-29 board.Sep 29 2015, 1:56 PM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Sep 29 2015, 3:28 PM
• Jonas renamed this task from initial default display of article placeholder to [Story] initial default display of article placeholder.Sep 30 2015, 10:11 AM
Lucie moved this task from Doing to Done on the Wikidata-Sprint-2015-09-29 board.Sep 30 2015, 5:30 PM
Lucie moved this task from Done to Doing on the Wikidata-Sprint-2015-09-29 board.

@hoo: "Other things that are probably missing: A top level factory, getters and setters."
I will add at least getters abd setters to close the ticket.

Lucie moved this task from Doing to Review on the ArticlePlaceholder board.Oct 2 2015, 3:22 PM
Lucie moved this task from Doing to Review on the Wikidata-Sprint-2015-09-29 board.
gerritbot added a comment.Oct 3 2015, 3:06 PM

Change 242919 had a related patch set uploaded (by Lucie Kaffee):
Add getter and setter for the default Lua libary.

https://gerrit.wikimedia.org/r/242919

gerritbot added a comment.Oct 6 2015, 4:21 PM

Change 242919 merged by jenkins-bot:
Add getter and setter for the default Lua libary.

https://gerrit.wikimedia.org/r/242919

Diffusion mentioned this in rMEXT3210ee40325a: Updated mediawiki/extensions Project: mediawiki/extensions/ArticlePlaceholder….Oct 6 2015, 4:21 PM
Diffusion mentioned this in rEARPd8cbf631ed35: Add getter and setter for the default Lua libary..Oct 6 2015, 4:25 PM
gerritbot added a comment.Oct 6 2015, 4:55 PM

Change 243953 had a related patch set uploaded (by Lucie Kaffee):
Don't show titles if there is no content

https://gerrit.wikimedia.org/r/243953

gerritbot added a comment.Oct 7 2015, 7:51 AM

Change 243953 merged by jenkins-bot:
Don't show titles if there is no content

https://gerrit.wikimedia.org/r/243953

Diffusion mentioned this in rMEXT6c4f8c081862: Updated mediawiki/extensions Project: mediawiki/extensions/ArticlePlaceholder….Oct 7 2015, 7:52 AM
Diffusion mentioned this in rEARP592fb80da33b: Don't show titles if there is no content.
Lucie closed this task as Resolved.Oct 10 2015, 1:23 PM
Lucie moved this task from Review to Done on the ArticlePlaceholder board.
Lucie moved this task from Review to Done on the Wikidata-Sprint-2015-09-29 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL