Page MenuHomePhabricator
Create Task
Maniphest T113983

Web font libraries pulled into mobile beta, visibly changes the fonts
Closed, ResolvedPublic
Actions

Description

Visit https://en.m.wikipedia.org/wiki/Henry_Miller?mobileaction=beta
and you'll notice the heading visibly changes font.
This seems to only happen in beta and seems to be the unexpected side effect of pulling in ext.uls.webfonts.mobile (and jquery.webfonts)

I'm not sure why this is loading in beta but I'm concerned about this making it to the stable site, especially given the size of these modules. I can understand it being loaded conditionally in certain circumstances but just to support the Linux Libertine font seems a huge trade-off I'm not willing to encourage.

Details

SubjectRepoBranchLines +/-
Set default value of ULSMobileWebfontsEnabled to falsemediawiki/extensions/UniversalLanguageSelectormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Sep 28 2015, 5:20 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Performance Issue, UniversalLanguageSelector, Performance-Team.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2015, 5:20 PM
ori triaged this task as High priority.Sep 28 2015, 6:07 PM
ori edited projects, added Language-Team; removed Performance-Team.
ori set Security to None.
• santhosh claimed this task.Sep 29 2015, 5:27 AM
• santhosh added a project: LE-CX6-Sprint break.
gerritbot subscribed.Sep 29 2015, 5:31 AM

Change 242060 had a related patch set uploaded (by Santhosh):
Set default value of ULSMobileWebfontsEnabled to false

https://gerrit.wikimedia.org/r/242060

gerritbot added a project: Patch-For-Review.Sep 29 2015, 5:31 AM
• santhosh moved this task from Backlog to In Review on the LE-CX6-Sprint break board.Sep 29 2015, 5:37 AM
gerritbot added a comment.Sep 29 2015, 5:46 AM

Change 242060 merged by jenkins-bot:
Set default value of ULSMobileWebfontsEnabled to false

https://gerrit.wikimedia.org/r/242060

• santhosh mentioned this in rMEXTc5946b89b8ab: Updated mediawiki/extensions Project….Sep 29 2015, 5:46 AM
• santhosh mentioned this in rEULS9fed40b83bcf: Set default value of ULSMobileWebfontsEnabled to false.Sep 29 2015, 5:49 AM
• santhosh moved this task from In Review to QA on the LE-CX6-Sprint break board.Sep 29 2015, 9:44 AM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 10:16 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:47 AM
Arrbee subscribed.Sep 30 2015, 12:07 PM

Checked on en.m.wikipedia.beta.wmflabs for the same page. Fonts do not change like earlier.

Arrbee moved this task from QA to Done on the LE-CX6-Sprint break board.Sep 30 2015, 12:07 PM
Jdlrobson closed this task as Resolved.Sep 30 2015, 4:09 PM

Thanks guys for the speedy fix!
Out of interest are there any plans to make wgULSMobileWebfontsEnabled and loaded by default? If so, under what circumstances?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL