Page MenuHomePhabricator

Remove deprecated use of require('file.yml')
Closed, ResolvedPublic

Description

https://github.com/nodeca/js-yaml#breaking-changes-in-2xx---3xx asks us to

Replace all occurences of require('xxxx.yml') by fs.readFileSync() + yaml.safeLoad()

The js-yaml package should probably be upgraded and this code should be changed.

This also triggers JSHint errors:

'yaml' is defined but never used.

Event Timeline

polybuildr raised the priority of this task from to Needs Triage.
polybuildr updated the task description. (Show Details)
polybuildr added a project: grrrit-wm.
polybuildr subscribed.

Change 241871 had a related patch set uploaded (by Polybuildr):
Update js-yaml and replace require()s with read file and yaml.safeLoad

https://gerrit.wikimedia.org/r/241871

Change 241871 merged by jenkins-bot:
Update js-yaml and replace require()s with read file and yaml.safeLoad

https://gerrit.wikimedia.org/r/241871

polybuildr claimed this task.