Page MenuHomePhabricator
Create Task
Maniphest T114038

remove beta invite insert from mobile web in December 2015
Closed, ResolvedPublic
Actions

Description

This should be feature flagged and disabled for December.
currently, ~5% see an invite to beta. So as to not dilute fundraising message, we should remove this during december.

Details

SubjectRepoBranchLines +/-
Disable the optin to beta message / make it configurablemediawiki/extensions/MobileFrontendwmf/1.27.0-wmf.7+25 -5
Disable beta optin experimentoperations/mediawiki-configmaster+15 -0
Disable the optin to beta message / make it configurablemediawiki/extensions/MobileFrontendmaster+25 -5
Customize query in gerrit

Event Timeline

• JKatzWMF created this task.Sep 28 2015, 9:55 PM
• JKatzWMF assigned this task to Jdlrobson.
• JKatzWMF raised the priority of this task from to Needs Triage.
• JKatzWMF updated the task description. (Show Details)
• JKatzWMF added a project: Web-Team-Backlog.
• JKatzWMF moved this task to Incoming on the Web-Team-Backlog board.
• JKatzWMF added subscribers: • JKatzWMF, MeganHernandez_WMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2015, 9:55 PM
Jdlrobson triaged this task as High priority.Sep 28 2015, 10:43 PM
Jdlrobson edited projects, added Reading-Web-Planning; removed Web-Team-Backlog.
Jdlrobson set Security to None.
Jdlrobson moved this task from To classify to Sprint 60: 8 on the Reading-Web-Planning board.Sep 30 2015, 8:27 PM
Jdlrobson updated the task description. (Show Details)Dec 1 2015, 7:38 PM
Jdlrobson edited projects, added Reading Web Sprint 61 - Cold Hard Cache; removed Reading-Web-Planning.
Jdlrobson moved this task from Sprint 60: 8 to 2016-17 Q1 on the Reading-Web-Planning board.Dec 1 2015, 7:42 PM
gerritbot subscribed.Dec 1 2015, 9:59 PM

Change 256348 had a related patch set uploaded (by Jdlrobson):
Disable the optin to beta message / make it configurable

https://gerrit.wikimedia.org/r/256348

gerritbot added a project: Patch-For-Review.Dec 1 2015, 9:59 PM
Jdlrobson moved this task from Needs Analysis to Code Review on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 1 2015, 9:59 PM
Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 2 2015, 4:45 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 3 2015, 12:04 AM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 3 2015, 3:40 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 3 2015, 6:19 PM
gerritbot added a comment.Dec 7 2015, 10:26 AM

Change 256348 merged by jenkins-bot:
Disable the optin to beta message / make it configurable

https://gerrit.wikimedia.org/r/256348

phuedx moved this task from Code Review to Ready for Signoff on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 7 2015, 10:32 AM
• bmansurov subscribed.Dec 7 2015, 11:07 AM

Don't we also have to submit patches to mediawiki-config with config variables?

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)).Dec 7 2015, 12:00 PM
phuedx subscribed.Dec 7 2015, 2:46 PM

@bmansurov: Since the extension is disabled by default, I believe not. I'll double-check now.

• bmansurov moved this task from Ready for Signoff to Done on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 7 2015, 4:13 PM
• atgo added subscribers: • jrobell, • atgo.Dec 7 2015, 6:40 PM

Hey guys, @jrobell saw this today. Can we make sure it comes down? Fundraising is supposed to start on mobile tomorrow.

• atgo added a comment.Dec 7 2015, 6:42 PM

IMG_5830 (1).PNG (688×387 px, 114 KB)

• atgo added a subscriber: Pcoombe.Dec 7 2015, 6:43 PM
• JKatzWMF added subscribers: K4-713, dr0ptp4kt, greg.Dec 7 2015, 6:46 PM

@Jdlrobson @bmansurov @dr0ptp4kt @greg @K4-713 @atgo

We need to deploy this asap since it is f-ing with our english campaign on mobile. @K4-713 can you confirm that this change is okay with fundraising?

greg added a comment.Dec 7 2015, 6:51 PM

Doit. Thanks for the catch.

gerritbot added a comment.Dec 7 2015, 7:50 PM

Change 257403 had a related patch set uploaded (by Jdlrobson):
Disable the optin to beta message / make it configurable

https://gerrit.wikimedia.org/r/257403

gerritbot added a comment.Dec 8 2015, 12:14 AM

Change 257503 had a related patch set uploaded (by Jdlrobson):
Disable beta optin experiment

https://gerrit.wikimedia.org/r/257503

gerritbot added a comment.Dec 8 2015, 12:17 AM

Change 257503 abandoned by Jdlrobson:
Disable beta optin experiment

Reason:
Not needed - seems that we disabled it. I got confused as it still shows with debug=true

https://gerrit.wikimedia.org/r/257503

gerritbot added a comment.Dec 8 2015, 12:29 AM

Change 257403 merged by Catrope:
Disable the optin to beta message / make it configurable

https://gerrit.wikimedia.org/r/257403

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-17_(1.27.0-wmf.7)).Dec 8 2015, 1:00 AM
Jdlrobson closed this task as Resolved.Dec 8 2015, 5:08 PM

This is now off

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL