Multiline TextInputWidget with indicator looks terrible.
Okay…
Hmm, this is getting kinda meh…
OH GOD WHAT IS THIS MY EYES
matmarex | |
Sep 28 2015, 10:24 PM |
F2912442: pasted_file | |
Nov 3 2015, 10:48 PM |
F2912447: pasted_file | |
Nov 3 2015, 10:48 PM |
F2912444: pasted_file | |
Nov 3 2015, 10:48 PM |
F2883220: pasted_file | |
Oct 27 2015, 10:10 PM |
F2724361: pasted_file | |
Oct 15 2015, 6:35 PM |
F2643848: pasted_file | |
Sep 28 2015, 10:24 PM |
F2643851: pasted_file | |
Sep 28 2015, 10:24 PM |
F2643854: pasted_file | |
Sep 28 2015, 10:24 PM |
Multiline TextInputWidget with indicator looks terrible.
Okay…
Hmm, this is getting kinda meh…
OH GOD WHAT IS THIS MY EYES
@matmarex Wow, that's not an easy one. As long as we don't have an ability to know, when a scrollbar is visible and add for example another CSS class to change the oo-ui-indicatorElement-indicator correspondingly, this will always be sore on the eyes.
Where is this actually used?
In the second step of the new file upload dialog in VisualEditor (Insert → Media → Upload).
Since we control the height manually, it should be possible to add some CSS class in OO.ui.TextInputWidget.prototype.adjustSize if the scrollbar is being displayed.
@Esanders and do you agree on that current layout having it vertically centered? I think in order to make it clear that it's an obligatory field it should be vertically-aligned on top, aligning with first line.
We'll probably have to calculate the scrollbar width, which is OS dependent: http://stackoverflow.com/questions/8079187/how-to-calculate-the-width-of-the-scroll-bar
Change 249381 had a related patch set uploaded (by Esanders):
TextInputWidget: Ensure icon indicator label are top aligned in multiline mode
Change 249395 had a related patch set uploaded (by Esanders):
TextInputWidget: Account for scroll bar width when positioning indicators/labels
Change 249381 merged by jenkins-bot:
TextInputWidget: Ensure icon indicator label are top aligned in multiline mode
Change 249395 merged by jenkins-bot:
TextInputWidget: Account for scroll bar width when positioning indicators/labels