Pholio:
Description
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| MediaWiki theme: Adjust RadioInputWidget to match M29 design | oojs/ui | master | +96 -51 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T114026 Minimize differences between implemented components and in pholio mock-ups | |||
| Resolved | Volker_E | T114050 Get RadioSelectInputWidget to design spec | |||
| Resolved | Volker_E | T115293 Standardize on component focus states | |||
| Resolved | matmarex | T133429 ButtonSelectWidget (ButtonOptionWidget) should receive a custom focus appearance |
Event Timeline
Note: This is another instance where computed pixel values of em units imply errors in bringing browser rendered widget to design spec.
@violetto Due to the restrictions of em unit rendering I also can't provide a precise spec implementation of the checked inner circle. It's not getting to 100% right size.
Change 244839 had a related patch set uploaded (by VolkerE):
Get RadioInputWidget to MediaWiki theme's design spec
@Jdforrester-WMF No, it's in my understanding stalled by the request about missing (one) clear generalized :focus states across all widgets, which Ed brought up on the CheckboxWidget.
Right now, I don't think so.
I'm in conversations with designers on the future of M101 and have raised the :focus issue as one of the long outstanding high priority things, as it's blocking two widgets from moving further and is connected to the discussion around :hover state on textInputWidgets – https://gerrit.wikimedia.org/r/#/c/264581/
Will get back to you…
@Jdforrester-WMF Reached out to @Nirzar and @Pginer-WMF to get alignment on checkbox/radio selected (wanted to write radio active :P) state.
Let's move this forward!
Change 244839 merged by jenkins-bot:
MediaWiki theme: Adjust RadioInputWidget to match M29 design

