Page MenuHomePhabricator

Get RadioSelectInputWidget to design spec
Closed, ResolvedPublic8 Estimated Story Points

Description

Details

Event Timeline

violetto assigned this task to Volker_E.
violetto raised the priority of this task from to Needs Triage.
violetto updated the task description. (Show Details)
violetto subscribed.

Note: This is another instance where computed pixel values of em units imply errors in bringing browser rendered widget to design spec.

@violetto Due to the restrictions of em unit rendering I also can't provide a precise spec implementation of the checked inner circle. It's not getting to 100% right size.

Change 244839 had a related patch set uploaded (by VolkerE):
Get RadioInputWidget to MediaWiki theme's design spec

https://gerrit.wikimedia.org/r/244839

matmarex subscribed.

Screenshot of the proposed implementation (T114049 / T114050 / T113225), for the lazy:

New design for OOjs UI checkbox/radio/toggle (509×390 px, 26 KB)

Jdforrester-WMF renamed this task from Getting RadioSelectInputWidget to design spec to Get RadioSelectInputWidget to design spec.Mar 2 2016, 2:00 AM
Jdforrester-WMF added a subscriber: Volker_E.
Jdforrester-WMF subscribed.

This one is also stalled because it's too blue?

@Jdforrester-WMF No, it's in my understanding stalled by the request about missing (one) clear generalized :focus states across all widgets, which Ed brought up on the CheckboxWidget.

OK. Is there anything I can do to help move this forward?

Right now, I don't think so.
I'm in conversations with designers on the future of M101 and have raised the :focus issue as one of the long outstanding high priority things, as it's blocking two widgets from moving further and is connected to the discussion around :hover state on textInputWidgets – https://gerrit.wikimedia.org/r/#/c/264581/
Will get back to you…

@Jdforrester-WMF Reached out to @Nirzar and @Pginer-WMF to get alignment on checkbox/radio selected (wanted to write radio active :P) state.
Let's move this forward!

Jdforrester-WMF changed the point value for this task from 1 to 8.May 30 2016, 5:12 PM

I think this comment was meant to go here:

Updated shots:

Before (as of 2016-09-12)After
Screen Shot 2016-09-12 at 08.41.41.png (767×653 px, 80 KB)
Screen Shot 2016-09-12 at 08.42.25.png (771×655 px, 80 KB)

I think it's OK, but perhaps we could use the selected (dark) blue rather than the progressive (mid) blue, yes.

Change 244839 merged by jenkins-bot:
MediaWiki theme: Adjust RadioInputWidget to match M29 design

https://gerrit.wikimedia.org/r/244839