Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| MediaWiki theme: Adjust ToggleSwitchWidget to match M61 design | oojs/ui | master | +54 -34 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T114026 Minimize differences between implemented components and in pholio mock-ups | |||
| Resolved | Volker_E | T114056 ToggleSwitchWidget's circle icon should be larger |
Event Timeline
Comment Actions
@violetto The circle icon is right now 1em (at 100% 14px in diameter calculated), the height of the full toggleSwitch including the border is set at 2em. The radio input circle is calculated 12px, but consists unlike the toggleSwitch of an SVG image, that is squeezed into 1.6em width/height.
The radio inputs should be 1em as well. As we all know, ems are relative to the root size.
Right now, I wonder where the difference of the circle size arises from, I guess it's anti-aliasing differences between Sketch and browser rendering engines or from rounding errors of em units?!
What should we do? Rise to 1.1em?
Sorry, updated my comment to 1.1em. Seems doable as well
Comment Actions
After you've seen it in reality and might agree on it, we need to change the mockups as well to reflect that.
Comment Actions
Change 244835 had a related patch set uploaded (by VolkerE):
Get ToggleSwitchWidget to MediaWiki theme's design spec
Comment Actions
Change 244835 merged by jenkins-bot:
MediaWiki theme: Adjust ToggleSwitchWidget to match M61 design