| Kaganer | |
| Sep 29 2015, 12:28 PM |
| F2644710: pasted_file | |
| Sep 29 2015, 12:28 PM |
| F2644703: pasted_file | |
| Sep 29 2015, 12:28 PM |
| F2644726: pasted_file | |
| Sep 29 2015, 12:28 PM |
Currently with using insertables their codes is inserted at left of the cursor or selected text. Selection thus canceled.
See example
Proposal: when insertion to replace selected text by a insertable code. Target results may be look as:
This would more user-friendly behavior.
Also reported on https://translatewiki.net/wiki/Thread:Support/Editing_in_the_AJAX_tool_-_using_klick_point_in_the_lower_left_edge.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Make Insertable without post content to replace selection | mediawiki/extensions/Translate | master | +16 -7 |
How would you know when to replace the existing selection and when to wrap the selection (for example {{PLURAL:$1|_}} wraps the selection at _)?
I don't see problem.
Difference - presence or absence of brackets.
I am proposing a patch which assumes “pre” value should fully replace selection as soon as there is no “post” value. That seems to fit with provided Insertables types.
Some user-developped Insertables can rely on current behavior, but from a final-user, that seems to be a strange expectation: the final user can place its carret before the world instead of selecting it, if they want to insert the Insertable before the word.
Change 822193 had a related patch set uploaded (by Pols12; author: Pols12):
[mediawiki/extensions/Translate@master] Make Insertable without post content to replace selection
Change 822193 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Make Insertable without post content to replace selection