Page MenuHomePhabricator

Semantic Versioning format for WMF deploy branches breaks Pywikibot
Closed, ResolvedPublic

Description

T67306 completely breaks Pywikibot's use on WMF wikis as we don't except other static characters around the wmf suffix. So the MediaWikiVersion handler considers it “another” style but it asserts that none of the handled strings appear in the “other” style (as it indicates that something was missed).

The parsing exists primarily to determine whether it is a pre-release version, or a post release suffix added by distributions.

However as Pywikibot also runs automated tests on beta cluster and test sites, the code occasionally needs to check for specific deploy branches before enabling a feature.

Event Timeline

jayvdb assigned this task to XZise.
jayvdb raised the priority of this task from to Unbreak Now!.
jayvdb updated the task description. (Show Details)
jayvdb added a project: Pywikibot.
jayvdb subscribed.

Change 242373 had a related patch set uploaded (by XZise):
[FIX] MediaWikiVersion: Accept new wmf style

https://gerrit.wikimedia.org/r/242373

XZise set Security to None.

Change 242390 had a related patch set uploaded (by XZise):
[FIX] MediaWikiVersion: Accept new wmf style

https://gerrit.wikimedia.org/r/242390

Change 242373 merged by jenkins-bot:
[FIX] MediaWikiVersion: Accept new wmf style

https://gerrit.wikimedia.org/r/242373

Change 242397 had a related patch set uploaded (by XZise):
[FIX] MediaWikiVersion: Accept new wmf style

https://gerrit.wikimedia.org/r/242397

Change 242397 abandoned by XZise:
[FIX] MediaWikiVersion: Accept new wmf style

Reason:
Wrong branch

https://gerrit.wikimedia.org/r/242397

Change 242390 merged by jenkins-bot:
[FIX] MediaWikiVersion: Accept new wmf style

https://gerrit.wikimedia.org/r/242390

This should be solved on both branches.