Page MenuHomePhabricator
Create Task
Maniphest T114198

Donate button on Amazon form should only show up when a card is selected
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

We're assuming the wallet widget renders with a default method selected. When this isn't the case, the SetOrderReferenceDetails call comes back with constraint 'PaymentPlanNotSet - The buyer has not been able to select a Payment method for the given Order Reference'.

Move the code that makes the Donate button appear from onOrderReferenceCreate to onPaymentSelected. Show message with links to alternate payment providers a couple seconds after onReady if no payment has been selected yet.

Details

SubjectRepoBranchLines +/-
Ensure card selected before clicking 'Donate'mediawiki/extensions/DonationInterfacemaster+35 -6
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Sep 30 2015, 12:05 AM
Ejegg claimed this task.
Ejegg raised the priority of this task from to Medium.
Ejegg updated the task description. (Show Details)
Ejegg added projects: MediaWiki-extensions-DonationInterface, Fundraising-Backlog, Fundraising Sprint Tom Waits, Unplanned-Sprint-Work.
Ejegg subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2015, 12:05 AM
Ejegg set Security to None.Sep 30 2015, 1:13 AM
Ejegg edited a custom field.
gerritbot subscribed.Sep 30 2015, 1:13 AM

Change 242432 had a related patch set uploaded (by Ejegg):
WIP Ensure card selected before clicking 'Donate'

https://gerrit.wikimedia.org/r/242432

gerritbot added a project: Patch-For-Review.Sep 30 2015, 1:13 AM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Tom Waits board.Sep 30 2015, 5:33 PM
• DStrine moved this task from Triage to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.Sep 30 2015, 8:50 PM
• DStrine added a project: Fundraising Sprint UB40.Sep 30 2015, 10:59 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint UB40 board.Sep 30 2015, 11:00 PM
• DStrine removed a project: Unplanned-Sprint-Work.Oct 1 2015, 5:16 PM
Ejegg moved this task from Doing to Review on the Fundraising Sprint Tom Waits board.Oct 2 2015, 8:18 PM
• DStrine moved this task from Closed Sprint Work Q1 1516 to Closed Sprint Work Completed in Q2 1516 on the Fundraising-Backlog board.Oct 5 2015, 5:30 PM
Ejegg moved this task from Doing to Review on the Fundraising Sprint UB40 board.Oct 5 2015, 8:45 PM
gerritbot added a comment.Oct 5 2015, 9:57 PM

Change 242432 merged by jenkins-bot:
Ensure card selected before clicking 'Donate'

https://gerrit.wikimedia.org/r/242432

awight mentioned this in rEDOI07a6e1d168ee: Ensure card selected before clicking 'Donate'.Oct 5 2015, 9:58 PM
Ejegg mentioned this in rMEXTfd6f1639b357: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Oct 5 2015, 9:58 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Oct 5 2015, 10:00 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint UB40 board.Oct 6 2015, 6:42 PM
• DStrine added a project: Fundraising Sprint Vengaboys.Oct 14 2015, 11:17 PM
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Vengaboys board.Oct 14 2015, 11:18 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Vengaboys board.Oct 15 2015, 8:04 PM
Ejegg closed this task as Resolved.Oct 20 2015, 3:41 PM
• DStrine added a project: Fundraising Sprint William Shatner.Oct 28 2015, 10:58 PM
• DStrine removed a project: Fundraising Sprint William Shatner.Oct 28 2015, 11:00 PM
• DStrine added a project: FR-Amazon.Nov 19 2015, 6:30 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL