Page MenuHomePhabricator
Create Task
Maniphest T114220

[Task] Add hook or mechanism in Wikibase for other extensions to register additional extension data in ParserOutput
Closed, ResolvedPublic
Actions

Description

we probably need a hook or some mechanism for other extensions such as GeoData and PageImages to add additional extension data in ParserOutput.

ideally the mechanism can be in such a way (e.g. maybe visitor pattern?) a that we only need to loop through the array of Snaks only once.

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects

Event Timeline

aude created this task.Sep 30 2015, 9:41 AM
aude raised the priority of this task from to Medium.
aude updated the task description. (Show Details)
aude added projects: Wikidata, MediaWiki-extensions-Wikibase-Repo.
aude subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2015, 9:41 AM
aude added a parent task: T75482: [Story] Make Wikibase add coordinates to GeoData on wikidata.org.Sep 30 2015, 9:42 AM
aude added a project: Wikidata-Sprint-2015-09-29.
aude set Security to None.
Tobi_WMDE_SW assigned this task to aude.Sep 30 2015, 10:19 AM
Tobi_WMDE_SW moved this task from Proposed to Doing on the Wikidata-Sprint-2015-09-29 board.
aude merged a task: T114113: Add a hook to EntityContent::getParserOutput to allow other extensions to register additional extension data.Oct 1 2015, 12:29 AM
aude moved this task from incoming to in progress on the Wikidata board.
gerritbot subscribed.Oct 5 2015, 7:11 AM

Change 243613 had a related patch set uploaded (by Aude):
Refactor ReferencedEntitiesFinder etc. into ParserOutputDataUpdates [WIP]

https://gerrit.wikimedia.org/r/243613

gerritbot added a project: Patch-For-Review.Oct 5 2015, 7:11 AM
gerritbot added a comment.Oct 8 2015, 4:04 PM

Change 244455 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Introduce ParserOutputDataUpdate infrastructure

https://gerrit.wikimedia.org/r/244455

gerritbot added a comment.Oct 9 2015, 8:23 AM

Change 244643 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Introduce ParserOutputDataUpdate infrastructure

https://gerrit.wikimedia.org/r/244643

gerritbot added a comment.Oct 9 2015, 9:03 AM

Change 244455 abandoned by Thiemo Mättig (WMDE):
Introduce ParserOutputDataUpdate infrastructure

Reason:
Resubmitted as I161821.

https://gerrit.wikimedia.org/r/244455

gerritbot added a comment.Oct 9 2015, 9:36 AM

Change 244648 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Introduce PropertyDataTypeMatcher and use in DataUpdates

https://gerrit.wikimedia.org/r/244648

JanZerebecki moved this task from Doing to Review on the Wikidata-Sprint-2015-09-29 board.Oct 12 2015, 12:09 PM
gerritbot added a comment.Oct 13 2015, 12:32 PM

Change 245868 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix badge handling in ReferencedEntitiesDataUpdate

https://gerrit.wikimedia.org/r/245868

Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-10-13.Oct 13 2015, 12:34 PM
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2015-10-13 board.
JanZerebecki added a parent task: T115325: [Task] run refreshLinks on wikidatawiki.Oct 13 2015, 1:29 PM
gerritbot added a comment.Oct 13 2015, 1:29 PM

Change 245873 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add strict type checks to EntityParserOutputDataUpdater

https://gerrit.wikimedia.org/r/245873

gerritbot added a comment.Oct 13 2015, 2:02 PM

Change 245878 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Inline EntityParserOutputDataUpdater into EntityParserOutputGenerator

https://gerrit.wikimedia.org/r/245878

gerritbot added a comment.Oct 13 2015, 2:59 PM

Change 245895 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add FIXMEs/refactor DataUpdates related interfaces and classes

https://gerrit.wikimedia.org/r/245895

gerritbot added a comment.Oct 13 2015, 6:40 PM

Change 244643 merged by jenkins-bot:
Introduce ParserOutputDataUpdate infrastructure

https://gerrit.wikimedia.org/r/244643

gerritbot added a comment.Oct 13 2015, 6:40 PM

Change 244648 merged by jenkins-bot:
Introduce PropertyDataTypeMatcher and use in DataUpdates

https://gerrit.wikimedia.org/r/244648

gerritbot added a comment.Oct 13 2015, 6:50 PM

Change 243613 merged by jenkins-bot:
Drop ReferencedEntitiesFinder, use EntityParserOutputDataUpdater instead.

https://gerrit.wikimedia.org/r/243613

gerritbot added a comment.Oct 13 2015, 7:03 PM

Change 245868 merged by jenkins-bot:
Fix badge handling in ReferencedEntitiesDataUpdate

https://gerrit.wikimedia.org/r/245868

gerritbot added a comment.Oct 13 2015, 7:07 PM

Change 245873 merged by jenkins-bot:
Add strict type checks to EntityParserOutputDataUpdater

https://gerrit.wikimedia.org/r/245873

gerritbot added a comment.Oct 14 2015, 10:23 AM

Change 246192 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Rework standalone PageImagesDataUpdate into a ParserOutputDataUpdate

https://gerrit.wikimedia.org/r/246192

Lydia_Pintscher renamed this task from Add hook or mechanism in Wikibase for other extensions to register additional extension data in ParserOutput to [Task] Add hook or mechanism in Wikibase for other extensions to register additional extension data in ParserOutput.Oct 14 2015, 12:28 PM
gerritbot added a comment.Oct 14 2015, 3:16 PM

Change 246192 merged by jenkins-bot:
Rework standalone PageImagesDataUpdate into a ParserOutputDataUpdate

https://gerrit.wikimedia.org/r/246192

daniel removed a parent task: T115325: [Task] run refreshLinks on wikidatawiki.Oct 14 2015, 3:34 PM
daniel removed a parent task: T75482: [Story] Make Wikibase add coordinates to GeoData on wikidata.org.
gerritbot added a comment.Oct 14 2015, 5:21 PM

Change 246270 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Simplify overcomplicated getters in DataUpdater implementations

https://gerrit.wikimedia.org/r/246270

gerritbot added a comment.Oct 14 2015, 5:34 PM

Change 246270 merged by jenkins-bot:
Simplify overcomplicated getters in DataUpdater implementations

https://gerrit.wikimedia.org/r/246270

gerritbot added a comment.Oct 14 2015, 6:08 PM

Change 246286 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove not needed getters from DataUpdater implementations

https://gerrit.wikimedia.org/r/246286

gerritbot added a comment.Oct 14 2015, 6:35 PM

Change 246292 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Move DataUpdate and related classes to ParserOutput namespace

https://gerrit.wikimedia.org/r/246292

gerritbot added a comment.Oct 14 2015, 10:20 PM

Change 246286 merged by jenkins-bot:
Remove not needed getters from DataUpdater implementations

https://gerrit.wikimedia.org/r/246286

Tobi_WMDE_SW moved this task from Review to Done on the Wikidata-Sprint-2015-10-13 board.Oct 15 2015, 8:32 AM
gerritbot added a comment.Oct 16 2015, 1:49 PM

Change 246834 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Minor clean-ups in ParserOutput DataUpdates code

https://gerrit.wikimedia.org/r/246834

gerritbot added a comment.Oct 16 2015, 4:20 PM

Change 246292 merged by jenkins-bot:
Move DataUpdate and related classes to ParserOutput namespace

https://gerrit.wikimedia.org/r/246292

gerritbot added a comment.Oct 28 2015, 4:19 PM

Change 245878 merged by jenkins-bot:
Inline the instantiation of EntityParserOutputDataUpdater into EntityParserOutputGenerator

https://gerrit.wikimedia.org/r/245878

gerritbot added a comment.Nov 1 2015, 6:57 PM

Change 246834 merged by jenkins-bot:
Minor clean-ups in ParserOutput DataUpdates code

https://gerrit.wikimedia.org/r/246834

• Jonas closed this task as Resolved.Nov 3 2015, 5:00 PM
gerritbot added a comment.Dec 15 2015, 10:00 AM

Change 259220 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add FIXMEs to DataUpdate related interfaces and classes

https://gerrit.wikimedia.org/r/259220

gerritbot added a comment.May 8 2019, 3:18 PM

Change 245895 abandoned by Thiemo Kreuz (WMDE):
Construct DataUpdaters in EntityParserOutputGenerator instead

https://gerrit.wikimedia.org/r/245895

gerritbot added a comment.May 8 2019, 3:19 PM

Change 259220 abandoned by Thiemo Kreuz (WMDE):
Add FIXMEs to DataUpdate related interfaces and classes

https://gerrit.wikimedia.org/r/259220

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits