Page MenuHomePhabricator

"Home" view is empty after legacy data migration runs
Closed, ResolvedPublic

Description

Steps to reproduce

  1. Install old version of the app (before 4.1.0)
  2. Save some pages and let them download
  3. Install new app over it
  4. Launch the app and start migration

Expected results

Data is successfully migrated, and Home view shows suggestions based on the (migrated) saved pages.

Actual results

Home view is empty:

pasted_file (1×750 px, 56 KB)


Dev Notes

If you try this right now, the assertions in WMFHomeViewController and WMFArticleListCollectionViewController will be triggered. This is due to the delay between viewDidAppear and loadMainUI caused by the data migration. There are a couple ways we can resolve this:

  1. Allow the tab root VCs to be reconfigured on the fly (i.e. Home, Saved, & Recent)
  2. Instantiate tab root VC's programmatically in the data migration callback

I vote for option 2 because it promotes immutability.

Event Timeline

JMinor triaged this task as Medium priority.Oct 2 2015, 3:48 AM
JMinor set Security to None.
MBinder_WMF subscribed.

This was closed as part of a pre-beta grooming with PO/Scrum Master/QA. Please ping @JMinor if there are questions.