[Regression ?] Context menu for link inspector does not appear after typing something after the link unless user goes to next line in Firefox
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Ryasmeen
	Oct 1 2015, 12:29 AM

Description

Steps to reproduce:

Open a page with VE
Add a link with link inspector

3.Type something right after the newly added link
5.Now place cursor on the link to edit the link

Observed Result:
Cannot edit the link I just added, double clicking also does not bring the context menu to edit. If i go to next line by pressing enter.
and place the cursor again on the link, the context menu for the link inspector re-appears.

Before going to next line or clicking anywhere else:

Screen Shot 2015-09-30 at 5.26.24 PM.png (262×505 px, 16 KB)

After coming back to the link:

Screen Shot 2015-09-30 at 5.28.06 PM.png (222×478 px, 19 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Better faking of onselectionchange	VisualEditor/VisualEditor	master	+7 -1

Customize query in gerrit

Event Timeline

Ryasmeen created this task.Oct 1 2015, 12:29 AM

Ryasmeen raised the priority of this task from to High.

Ryasmeen updated the task description. (Show Details)

Ryasmeen added a project: VisualEditor.

Ryasmeen subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2015, 12:29 AM

Ryasmeen renamed this task from [Regression ?] Context menu for link inspector does not appear after typinf something after the link unless user goes to next line to [Regression ?] Context menu for link inspector does not appear after typing something after the link unless user goes to next line.Oct 1 2015, 12:29 AM

Ryasmeen set Security to None.

I can't reproduce now. Can you?

Jdforrester-WMF changed the task status from Open to Stalled.Oct 5 2015, 6:04 PM

Jdforrester-WMF added a project: VisualEditor-MediaWiki-Links.

yes I can.
Screen capture attached.

Link inspector context menu not appearing.mov6 MBDownload

Jdforrester-WMF lowered the priority of this task from High to Low.Oct 20 2015, 7:24 PM

Jdforrester-WMF edited a custom field.

Jdforrester-WMF moved this task from To Triage to Needs Discussion/Analysis on the VisualEditor board.

Works fine in Chrome. Error is only reproducible in Firefox.

Turns out: error is reproducible in browsers that don't have selection change events enabled, because the way we're faking them doesn't quite work for non "dragging to select text" cases.

Jdforrester-WMF added a project: Browser-Support-Firefox.Nov 12 2015, 1:09 AM

Change 252613 had a related patch set uploaded (by DLynch):
Better faking of onselectionchange

https://gerrit.wikimedia.org/r/252613

gerritbot added a project: Patch-For-Review.Nov 12 2015, 1:12 AM

Jdforrester-WMF renamed this task from [Regression ?] Context menu for link inspector does not appear after typing something after the link unless user goes to next line to [Regression ?] Context menu for link inspector does not appear after typing something after the link unless user goes to next line in Firefox.Nov 12 2015, 3:50 PM

Jdforrester-WMF closed this task as Resolved.

Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-11-17_(1.27.0-wmf.7)); removed Patch-For-Review.

This is still happening for me on Firefox. Context menu is not appearing when I put my cursor on the link without going to the next line.

The VisualEditor extension hasn't had its VE core reference updated yet, so the beta cluster won't have this fix.

	F2957801: Screen Shot 2015-11-12 at 11.33.59 AM.png
	Nov 12 2015, 7:35 PM

	F2662546: Link inspector context menu not appearing.mov
	Oct 6 2015, 7:55 PM

	F2647696: Screen Shot 2015-09-30 at 5.26.24 PM.png
	Oct 1 2015, 12:29 AM

	F2647698: Screen Shot 2015-09-30 at 5.28.06 PM.png
	Oct 1 2015, 12:29 AM

[Regression ?] Context menu for link inspector does not appear after typing something after the link unless user goes to next line in FirefoxClosed, ResolvedPublic8 Estimated Story PointsActions

Description

Details

Event Timeline

[Regression ?] Context menu for link inspector does not appear after typing something after the link unless user goes to next line in Firefox
Closed, ResolvedPublic8 Estimated Story Points
Actions