Page MenuHomePhabricator

"toc" is not treated as a valid parameter by the pagebanner extension
Closed, ResolvedPublic

Description

All page banners on Wikivoyage are being added to the new "Category:WikidataPageBanner with unknown parameters" by the banner extension, due apparently to using the "toc" parameter. According to https://www.mediawiki.org/wiki/Extension:WikidataPageBanner "toc" is a valid parameter, so either the documentation is wrong or the extension is incorrect.

See https://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#Banner_error_category for further details.

Details

Related Gerrit Patches:
mediawiki/extensions/WikidataPageBanner : masterAdd `toc` as a valid parameter

Event Timeline

Wrh2 created this task.Oct 1 2015, 5:38 AM
Wrh2 assigned this task to Jdlrobson.
Wrh2 raised the priority of this task from to Normal.
Wrh2 updated the task description. (Show Details)
Wrh2 added a project: Wikidata-Page-Banner.
Wrh2 added a subscriber: Wrh2.
Restricted Application added a project: Wikidata. · View Herald TranscriptOct 1 2015, 5:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Oct 1 2015, 11:18 AM
Jdlrobson removed Jdlrobson as the assignee of this task.Oct 1 2015, 4:49 PM
Jdlrobson raised the priority of this task from Normal to High.
Jdlrobson set Security to None.

Change 242921 had a related patch set uploaded (by Jdlrobson):
Add toc as a valid parameter

https://gerrit.wikimedia.org/r/242921

Change 242921 merged by jenkins-bot:
Add toc as a valid parameter

https://gerrit.wikimedia.org/r/242921

Florian closed this task as Resolved.Oct 2 2015, 7:11 PM
Florian assigned this task to Jdlrobson.
Florian removed a project: Patch-For-Review.