Page MenuHomePhabricator

mw.Uri ignores keys in query string which are the name of a JavaScript Object prototype
Closed, ResolvedPublic

Description

mw.Uri ignores keys in query string which are the name of a JavaScript Object prototype.

new mw.Uri( 'http://example.com/index.php?key=key&hasOwnProperty=hasOwnProperty&constructor=constructor&watch=watch' ).query

evaluates (on Firefox) to

Object { key="key" }

expected result

Object { key="key", hasOwnProperty="hasOwnProperty", constructor="constructor", watch="watch" }

Details

Related Gerrit Patches:

Event Timeline

Fomafix created this task.Oct 1 2015, 7:41 AM
Fomafix claimed this task.
Fomafix raised the priority of this task from to Medium.
Fomafix updated the task description. (Show Details)
Fomafix added a subscriber: Fomafix.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2015, 7:41 AM

Change 242815 had a related patch set uploaded (by Gerrit Patch Uploader):
mediawiki.Uri: Support names of Object prototypes as keys in query string

https://gerrit.wikimedia.org/r/242815

Change 242815 merged by jenkins-bot:
mediawiki.Uri: Support names of Object prototypes as keys in query

https://gerrit.wikimedia.org/r/242815

matmarex closed this task as Resolved.Oct 2 2015, 12:24 PM
matmarex removed a project: Patch-For-Review.
matmarex set Security to None.
matmarex added a subscriber: matmarex.