mw.Uri ignores keys in query string which are the name of a JavaScript Object prototype
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Fomafix
	Oct 1 2015, 7:41 AM

Description

mw.Uri ignores keys in query string which are the name of a JavaScript Object prototype.

new mw.Uri( 'http://example.com/index.php?key=key&hasOwnProperty=hasOwnProperty&constructor=constructor&watch=watch' ).query

evaluates (on Firefox) to

Object { key="key" }

expected result

Object { key="key", hasOwnProperty="hasOwnProperty", constructor="constructor", watch="watch" }

	Subject	Repo	Branch	Lines +/-
	mediawiki.Uri: Support names of Object prototypes as keys in query	mediawiki/core	master	+18 -3

Mentioned In: rMWa0628e5c2231: mediawiki.Uri: Support names of Object prototypes as keys in query

Fomafix claimed this task.

Fomafix raised the priority of this task from to Medium.

Fomafix updated the task description. (Show Details)

Fomafix subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2015, 7:41 AM

Change 242815 had a related patch set uploaded (by Gerrit Patch Uploader):
mediawiki.Uri: Support names of Object prototypes as keys in query string

Change 242815 merged by jenkins-bot:
mediawiki.Uri: Support names of Object prototypes as keys in query

matmarex closed this task as Resolved.Oct 2 2015, 12:24 PM

matmarex set Security to None.

matmarex subscribed.