Infusing a widget should be able to reuse existing DOM rather than recreate from scratch
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Oct 1 2015, 7:29 PM

Description

Infusing a widget should reuse existing DOM rather than recreate from scratch, when possible (for widgets where the DOM is the same, or very similar, in PHP and JS).

It would potentially be faster (fewer DOM operations)
It would avoid interfering with browser's built-in functionality
- T106313: Infusion breaks browser autofocus: partially fixed, my patch to fix it completely is so complicated it's been waiting two months for any reviews
- T114134: Special:MovePage interface loses what it had in the new title field if you go to a new page and then come back to it: probably impossible to work around efficiently and reliably

Details

Subject	Repo	Branch	Lines +/-
InputWidget: Actually reuse parts of the DOM when infusing	oojs/ui	master	+15 -13
WIP: Preserve DOM node of InputWidget's $input when infusing.	oojs/ui	master	+75 -72
Allow widgets to reuse parts of the DOM when infusing, use it for InputWidget's $input	oojs/ui	master	+64 -33

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		matmarex	T114134 Special:MovePage interface loses what it had in the new title field if you go to a new page and then come back to it
		Resolved		matmarex	T114408 Infusing a widget should be able to reuse existing DOM rather than recreate from scratch

Event Timeline

matmarex created this task.Oct 1 2015, 7:29 PM

matmarex raised the priority of this task from to Low.

matmarex updated the task description. (Show Details)

matmarex added a project: OOUI.

matmarex added subscribers: matmarex, cscott, Catrope.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2015, 7:29 PM

Ricordisamoa subscribed.Oct 1 2015, 7:31 PM

I'm not sure I agree with the "should" here, at least not without qualifiers.

"There should be a mechanism to allow..." I agree with. But we need to trade off implementation complexity -- we introduce a whole bunch of new ways to break things if we try to reuse the DOM blindly. So I think it's best to concentrate on high-reward areas where its worth the extra maintenance costs, and of course, not infusing any more widgets than we actually need to.

But input widgets do seem to be a special case worth accomodating.

Change 244047 had a related patch set uploaded (by Cscott):
WIP: Preserve DOM node of InputWidget's $input when infusing.

https://gerrit.wikimedia.org/r/244047

gerritbot added a project: Patch-For-Review.Oct 6 2015, 8:31 PM

matmarex renamed this task from Infusing a widget should reuse existing DOM rather than recreate from scratch to Infusing a widget should be able to reuse existing DOM rather than recreate from scratch.Oct 15 2015, 7:59 PM

matmarex set Security to None.

matmarex added a parent task: T114134: Special:MovePage interface loses what it had in the new title field if you go to a new page and then come back to it.Oct 23 2015, 6:41 PM

Change 243082 had a related patch set uploaded (by Bartosz Dziewoński):
Allow widgets to reuse parts of the DOM when infusing, use it for InputWidget's $input

https://gerrit.wikimedia.org/r/243082

Jdforrester-WMF closed this task as Resolved.Nov 3 2015, 6:17 PM

Jdforrester-WMF assigned this task to matmarex.

Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.

Change 243082 merged by jenkins-bot:
Allow widgets to reuse parts of the DOM when infusing, use it for InputWidget's $input

https://gerrit.wikimedia.org/r/243082

Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.13.1), MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)); removed OOjs-UI-next-release.Nov 3 2015, 10:52 PM

Note that this patch is basically the minimal useful thing. We still recreate all the DOM in almost all widgets, and almost all DOM in the rest of the widgets (InputWidget subclasses).

Change 244047 abandoned by Bartosz Dziewoński:
WIP: Preserve DOM node of InputWidget's $input when infusing.

Reason:
Folded into https://gerrit.wikimedia.org/r/#/c/243082/ , thanks!

https://gerrit.wikimedia.org/r/244047

Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Nov 21 2015, 2:30 AM

This doesn't work… what the hell was I thinking. It obviously doesn't work and I deserve a trouting.

(Even thought it's completely broken, this patch still fixed T114134 somehow. I wish I knew why.)

Change 277437 had a related patch set uploaded (by Bartosz Dziewoński):
InputWidget: Actually reuse parts of the DOM when infusing

https://gerrit.wikimedia.org/r/277437

gerritbot added a project: Patch-For-Review.Mar 15 2016, 1:04 AM

• MZMcBride subscribed.Mar 15 2016, 1:36 AM

Change 277437 merged by Jforrester:
InputWidget: Actually reuse parts of the DOM when infusing

https://gerrit.wikimedia.org/r/277437

Jdforrester-WMF closed this task as Resolved.Mar 15 2016, 3:35 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Infusing a widget should be able to reuse existing DOM rather than recreate from scratchClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Infusing a widget should be able to reuse existing DOM rather than recreate from scratch
Closed, ResolvedPublic
Actions

Related Objects
Search...